Fix build error with gcc 4.8.2 about WARN_UNUSED_RESULT

Fix build error with gcc 4.8.2 about WARN_UNUSED_RESULT

For static methods it does not seem to work properly with older gcc.
Indeed the compiler consider the result as not used in this example:

sequence_token_ = BrowserThread::GetBlockingPool()->GetSequenceToken()

"error: ignoring return value of 'static base::SequencedWorkerPool*
content::BrowserThread::GetBlockingPool()', declared with attribute
warn_unused_result [-Werror=unused-result]"

The solution is just to call GetSequenceToken() directly as:
base::SequencedWorkerPool::GetSequenceToken() as it is static.

BUG=579461
R=cpu@chromium.org, nico@chromium.org

TEST= GYP_DEFINES="clang=0 use_sysroot=0"

Committed: https://crrev.com/23df969355caed40d16791d22ad35929a6553f9b
Cr-Commit-Position: refs/heads/master@{#371479}

[Julien Isorce Samsung, 2016-01-20 10:33:30]

Description was changed from

==========
Fix build error with gcc 4.8.2 about WARN_UNUSED_RESULT

For static methods it does not seem to work properly with older gcc.
Indeed the compiler consider the result as not used in this example:

sequence_token_ = BrowserThread::GetBlockingPool()->GetSequenceToken()

"error: ignoring return value of 'static base::SequencedWorkerPool*
content::BrowserThread::GetBlockingPool()', declared with attribute
warn_unused_result [-Werror=unused-result]"

The solution is just to call GetSequenceToken() directly as:
base::SequencedWorkerPool::GetSequenceToken() as it is static.

BUG=579461

R=

TEST= GYP_DEFINES="clang=0 use_sysroot=0"
==========

to

==========
Fix build error with gcc 4.8.2 about WARN_UNUSED_RESULT

For static methods it does not seem to work properly with older gcc.
Indeed the compiler consider the result as not used in this example:

sequence_token_ = BrowserThread::GetBlockingPool()->GetSequenceToken()

"error: ignoring return value of 'static base::SequencedWorkerPool*
content::BrowserThread::GetBlockingPool()', declared with attribute
warn_unused_result [-Werror=unused-result]"

The solution is just to call GetSequenceToken() directly as:
base::SequencedWorkerPool::GetSequenceToken() as it is static.

BUG=579461

R=

TEST= GYP_DEFINES="clang=0 use_sysroot=0"
==========

[Julien Isorce Samsung, 2016-01-20 10:33:30]

j.isorce@samsung.com changed reviewers:
+ cpu@chromium.org

[cpu_(ooo_6.6-7.5), 2016-01-21 19:14:40]

cpu@chromium.org changed reviewers:
+ thakis@chromium.org

[cpu_(ooo_6.6-7.5), 2016-01-21 19:15:28]

Nico, do we usually accept these changes aimed at older GCCs?

[Nico, 2016-01-21 19:18:41]

"it depends". If it's a useful warning, yes. In this case, it looks like a
compiler bug workaround. It doesn't make the code much more ugly, so it might be
ok.

Maybe we should just disable this warning instead, or only turn on -Werror with
clang.

[Nico, 2016-01-25 23:23:36]

lgtm, calling static methods though an object is kind of weird imho, so changing
this seems like a good change.

[cpu_(ooo_6.6-7.5), 2016-01-25 23:28:06]

lgtm

[Julien Isorce Samsung, 2016-01-26 07:43:22]

Description was changed from

==========
Fix build error with gcc 4.8.2 about WARN_UNUSED_RESULT

For static methods it does not seem to work properly with older gcc.
Indeed the compiler consider the result as not used in this example:

sequence_token_ = BrowserThread::GetBlockingPool()->GetSequenceToken()

"error: ignoring return value of 'static base::SequencedWorkerPool*
content::BrowserThread::GetBlockingPool()', declared with attribute
warn_unused_result [-Werror=unused-result]"

The solution is just to call GetSequenceToken() directly as:
base::SequencedWorkerPool::GetSequenceToken() as it is static.

BUG=579461

R=

TEST= GYP_DEFINES="clang=0 use_sysroot=0"
==========

to

==========
Fix build error with gcc 4.8.2 about WARN_UNUSED_RESULT

For static methods it does not seem to work properly with older gcc.
Indeed the compiler consider the result as not used in this example:

sequence_token_ = BrowserThread::GetBlockingPool()->GetSequenceToken()

"error: ignoring return value of 'static base::SequencedWorkerPool*
content::BrowserThread::GetBlockingPool()', declared with attribute
warn_unused_result [-Werror=unused-result]"

The solution is just to call GetSequenceToken() directly as:
base::SequencedWorkerPool::GetSequenceToken() as it is static.

BUG=579461

R=cpu@chromium.org, nico@chromium.org

TEST= GYP_DEFINES="clang=0 use_sysroot=0"
==========

[Julien Isorce Samsung, 2016-01-26 07:43:33]

The CQ bit was checked by j.isorce@samsung.com

[commit-bot: I haz the power, 2016-01-26 07:43:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1610103002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1610103002/1

[commit-bot: I haz the power, 2016-01-26 09:08:58]

Description was changed from

==========
Fix build error with gcc 4.8.2 about WARN_UNUSED_RESULT

For static methods it does not seem to work properly with older gcc.
Indeed the compiler consider the result as not used in this example:

sequence_token_ = BrowserThread::GetBlockingPool()->GetSequenceToken()

"error: ignoring return value of 'static base::SequencedWorkerPool*
content::BrowserThread::GetBlockingPool()', declared with attribute
warn_unused_result [-Werror=unused-result]"

The solution is just to call GetSequenceToken() directly as:
base::SequencedWorkerPool::GetSequenceToken() as it is static.

BUG=579461

R=cpu@chromium.org, nico@chromium.org

TEST= GYP_DEFINES="clang=0 use_sysroot=0"
==========

to

==========
Fix build error with gcc 4.8.2 about WARN_UNUSED_RESULT

For static methods it does not seem to work properly with older gcc.
Indeed the compiler consider the result as not used in this example:

sequence_token_ = BrowserThread::GetBlockingPool()->GetSequenceToken()

"error: ignoring return value of 'static base::SequencedWorkerPool*
content::BrowserThread::GetBlockingPool()', declared with attribute
warn_unused_result [-Werror=unused-result]"

The solution is just to call GetSequenceToken() directly as:
base::SequencedWorkerPool::GetSequenceToken() as it is static.

BUG=579461

R=cpu@chromium.org, nico@chromium.org

TEST= GYP_DEFINES="clang=0 use_sysroot=0"
==========

[commit-bot: I haz the power, 2016-01-26 09:09:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-26 09:10:21]

Description was changed from

==========
Fix build error with gcc 4.8.2 about WARN_UNUSED_RESULT

For static methods it does not seem to work properly with older gcc.
Indeed the compiler consider the result as not used in this example:

sequence_token_ = BrowserThread::GetBlockingPool()->GetSequenceToken()

"error: ignoring return value of 'static base::SequencedWorkerPool*
content::BrowserThread::GetBlockingPool()', declared with attribute
warn_unused_result [-Werror=unused-result]"

The solution is just to call GetSequenceToken() directly as:
base::SequencedWorkerPool::GetSequenceToken() as it is static.

BUG=579461

R=cpu@chromium.org, nico@chromium.org

TEST= GYP_DEFINES="clang=0 use_sysroot=0"
==========

to

==========
Fix build error with gcc 4.8.2 about WARN_UNUSED_RESULT

For static methods it does not seem to work properly with older gcc.
Indeed the compiler consider the result as not used in this example:

sequence_token_ = BrowserThread::GetBlockingPool()->GetSequenceToken()

"error: ignoring return value of 'static base::SequencedWorkerPool*
content::BrowserThread::GetBlockingPool()', declared with attribute
warn_unused_result [-Werror=unused-result]"

The solution is just to call GetSequenceToken() directly as:
base::SequencedWorkerPool::GetSequenceToken() as it is static.

BUG=579461

R=cpu@chromium.org, nico@chromium.org

TEST= GYP_DEFINES="clang=0 use_sysroot=0"

Committed: https://crrev.com/23df969355caed40d16791d22ad35929a6553f9b
Cr-Commit-Position: refs/heads/master@{#371479}
==========

[commit-bot: I haz the power, 2016-01-26 09:10:22]

Patchset 1 (id:??) landed as
https://crrev.com/23df969355caed40d16791d22ad35929a6553f9b
Cr-Commit-Position: refs/heads/master@{#371479}