Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1610073002: [debugger] negative conditional break points mute breaks and exceptions. (Closed)

Created:
4 years, 11 months ago by Yang
Modified:
4 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] negative conditional break points mute breaks and exceptions. A break location is considered muted if it has break points, but their conditions all evaluate to false. Aside from not triggering break events, debugger statements and exceptions are also ignored. R=verwaest@chromium.org BUG=chromium:429167 LOG=Y Committed: https://crrev.com/0e4cae13f4e5ffae5398151166edc104c1c16a9c Cr-Commit-Position: refs/heads/master@{#33429}

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -37 lines) Patch
M src/debug/debug.h View 2 chunks +10 lines, -1 line 0 comments Download
M src/debug/debug.cc View 8 chunks +53 lines, -31 lines 0 comments Download
M src/debug/debug-scopes.cc View 1 chunk +1 line, -5 lines 0 comments Download
A test/mjsunit/debug-negative-break-points.js View 1 1 chunk +83 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Yang
4 years, 11 months ago (2016-01-20 09:23:55 UTC) #1
Toon Verwaest
lgtm
4 years, 11 months ago (2016-01-21 10:08:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610073002/20001
4 years, 11 months ago (2016-01-21 10:16:11 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 10:41:12 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 10:41:37 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0e4cae13f4e5ffae5398151166edc104c1c16a9c
Cr-Commit-Position: refs/heads/master@{#33429}

Powered by Google App Engine
This is Rietveld 408576698