third_party/WebKit/Source/core/paint/TableCellPainter.cpp - Issue 1610063002: Revert of Remove PaintInfo's paintingRoot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/TableCellPainter.cpp

Issue 1610063002: Revert of Remove PaintInfo's paintingRoot (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp ('k') | third_party/WebKit/Source/core/paint/TablePainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/TableCellPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/TableCellPainter.cpp b/third_party/WebKit/Source/core/paint/TableCellPainter.cpp

index 2b0f09b543e3c36139e80da8191fc6b358fb4569..c6372e500b97001ce68ee42e1abf060f151e5c78 100644

--- a/third_party/WebKit/Source/core/paint/TableCellPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/TableCellPainter.cpp

@@ -66,7 +66,7 @@

void TableCellPainter::paintCollapsedBorders(const PaintInfo& paintInfo, const LayoutPoint& paintOffset, const CollapsedBorderValue& currentBorderValue)

{

- if (m_layoutTableCell.style()->visibility() != VISIBLE)

+ if (!paintInfo.shouldPaintWithinRoot(&m_layoutTableCell) || m_layoutTableCell.style()->visibility() != VISIBLE)

return;

const ComputedStyle& styleForCellFlow = m_layoutTableCell.styleForCellFlow();

@@ -133,6 +133,9 @@

void TableCellPainter::paintBackgroundsBehindCell(const PaintInfo& paintInfo, const LayoutPoint& paintOffset, const LayoutObject* backgroundObject, DisplayItem::Type type)

{

+ if (!paintInfo.shouldPaintWithinRoot(&m_layoutTableCell))

+ return;

if (!backgroundObject)

return;

@@ -174,6 +177,9 @@

void TableCellPainter::paintBoxDecorationBackground(const PaintInfo& paintInfo, const LayoutPoint& paintOffset)

{

+ if (!paintInfo.shouldPaintWithinRoot(&m_layoutTableCell))

+ return;

LayoutTable* table = m_layoutTableCell.table();

if (!table->collapseBorders() && m_layoutTableCell.style()->emptyCells() == HIDE && !m_layoutTableCell.firstChild())

return;