Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1610063002: Revert of Remove PaintInfo's paintingRoot (Closed)

Created:
4 years, 11 months ago by pdr.
Modified:
4 years, 11 months ago
Reviewers:
chrishtr, Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove PaintInfo's paintingRoot (patchset #5 id:80001 of https://codereview.chromium.org/1602513004/ ) Reason for revert: Broke oilpan and closed the tree: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan%20Builder/builds/673/steps/compile/logs/stdio I'll fix this tomorrow and reland. Original issue's description: > Remove PaintInfo's paintingRoot > > PaintInfo had a paintingRoot member for supporting drawing a single > layout object (including descendants). This complexity is spread > throughout the painting code and only exists to support drag and drop > drag images: > https://chromium.googlesource.com/chromium/src/+/65e7e9d4860e50bb677228f0b83848cce208eb76 > > This patch switches to directly painting LayoutObjects and removes the > complex paintingRoot code. > > ClusterTelemetry results: 0.5% record time savings: > https://storage.cloud.google.com/cluster-telemetry/tasks/chromium_perf_runs/pdr-20160118203222/html/index.html > > BUG=577004 > > Committed: https://crrev.com/63c9596d206c896b35ae8a5bff4db73847f62f33 > Cr-Commit-Position: refs/heads/master@{#370334} TBR=chrishtr@chromium.org,wangxianzhu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=577004 Committed: https://crrev.com/ce37a6c4442ded2ffd29703b27d77e126528f3f4 Cr-Commit-Position: refs/heads/master@{#370335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -164 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 5 chunks +64 lines, -75 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 3 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 3 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FieldsetPainter.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 3 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp View 3 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInfo.h View 4 chunks +9 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInfo.cpp View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.h View 2 chunks +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 11 chunks +65 lines, -59 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ReplacedPainter.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/RootInlineBoxPainter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.cpp View 3 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/TablePainter.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ViewPainter.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pdr.
Created Revert of Remove PaintInfo's paintingRoot
4 years, 11 months ago (2016-01-20 06:56:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610063002/1
4 years, 11 months ago (2016-01-20 06:56:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 06:58:22 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 06:59:43 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce37a6c4442ded2ffd29703b27d77e126528f3f4
Cr-Commit-Position: refs/heads/master@{#370335}

Powered by Google App Engine
This is Rietveld 408576698