Convert base::Callback move-only support tests to be type parameterized.

Convert base::Callback move-only support tests to be type parameterized.

- Deduplicates copy and pasted test logic for scoped_ptr and
  std::unique_ptr.
- Adds test coverage of std::unique_ptr with a custom deleter.

BUG=561749
Committed: https://crrev.com/f10b7732d68db797aa14195149882b2f928f3b54
Cr-Commit-Position: refs/heads/master@{#370750}

[dcheng, 2016-01-20 06:17:38]

dcheng@chromium.org changed reviewers:
+ thakis@chromium.org

[dcheng, 2016-01-20 06:18:24]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 06:18:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1610053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1610053002/1

[commit-bot: I haz the power, 2016-01-20 06:41:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 06:41:03]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-01-21 17:29:14]

lgtm

(personally i don't like TYPED_TEST_CASE and would just have added another test
case for a custom deleter. some repetition in tests is fine if it makes tests
easier to understand imo. tests isn't the place to be clever)

https://codereview.chromium.org/1610053002/diff/1/base/bind_unittest.cc
File base/bind_unittest.cc (right):

https://codereview.chromium.org/1610053002/diff/1/base/bind_unittest.cc#newco...
base/bind_unittest.cc:724: using DeleteCounterPtr = T;
is this used for anything?

[dcheng, 2016-01-21 19:15:32]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-01-21 19:15:33]

https://codereview.chromium.org/1610053002/diff/1/base/bind_unittest.cc
File base/bind_unittest.cc (right):

https://codereview.chromium.org/1610053002/diff/1/base/bind_unittest.cc#newco...
base/bind_unittest.cc:724: using DeleteCounterPtr = T;
On 2016/01/21 at 17:29:14, Nico wrote:
> is this used for anything?

Done.

[dcheng, 2016-01-21 19:15:33]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1610053002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-01-21 19:16:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1610053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1610053002/20001

[commit-bot: I haz the power, 2016-01-21 19:38:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-21 19:39:51]

Description was changed from

==========
Convert base::Callback move-only support tests to be type parameterized.

- Deduplicates copy and pasted test logic for scoped_ptr and
  std::unique_ptr.
- Adds test coverage of std::unique_ptr with a custom deleter.

BUG=561749
==========

to

==========
Convert base::Callback move-only support tests to be type parameterized.

- Deduplicates copy and pasted test logic for scoped_ptr and
  std::unique_ptr.
- Adds test coverage of std::unique_ptr with a custom deleter.

BUG=561749

Committed: https://crrev.com/f10b7732d68db797aa14195149882b2f928f3b54
Cr-Commit-Position: refs/heads/master@{#370750}
==========

[commit-bot: I haz the power, 2016-01-21 19:39:51]

Patchset 2 (id:??) landed as
https://crrev.com/f10b7732d68db797aa14195149882b2f928f3b54
Cr-Commit-Position: refs/heads/master@{#370750}