Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1610043002: Add propagated types to summary files. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add propagated types to summary files. Note: the prelinker doesn't support type propagation, since type propagation may require looking at files beyond direct imports and the transitive closure of exports. However, to pave the way for a future implementation of a full linker, we still maintain the distinction between linked and unlinked data. The unlinked data for a propagated type is simply a unique "slot id" for each type in the compilation unit which may be propagated. The linked data is the propagated type to fill into each slot, if any. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c6dd4a3967dc49c7402f5e139e4f4ca390d298a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+871 lines, -176 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 34 chunks +227 lines, -32 lines 0 comments Download
M pkg/analyzer/lib/src/summary/prelink.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 8 chunks +42 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 2 chunks +14 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 10 chunks +131 lines, -40 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 3 chunks +65 lines, -58 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 17 chunks +336 lines, -31 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 6 chunks +54 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-20 05:54:45 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-20 06:31:09 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-20 14:36:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c6dd4a3967dc49c7402f5e139e4f4ca390d298a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698