Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: content/browser/loader/cross_site_resource_handler.cc

Issue 161003002: Do not trigger CrossSiteResourceHandler for streams or user certs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add a TODO. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/buffered_resource_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/cross_site_resource_handler.cc
diff --git a/content/browser/loader/cross_site_resource_handler.cc b/content/browser/loader/cross_site_resource_handler.cc
index 5bed76777c540a5e31b4017247d83f2f6d651e72..8c934657ad9cb7dce1c05d4a555764dcdd12b832 100644
--- a/content/browser/loader/cross_site_resource_handler.cc
+++ b/content/browser/loader/cross_site_resource_handler.cc
@@ -161,7 +161,10 @@ bool CrossSiteResourceHandler::OnResponseStarted(
// navigation) will stick around until the next cross-site navigation, since
// we are unable to tell when to destroy it.
// See RenderFrameHostManager::RendererAbortedProvisionalLoad.
- if (!swap_needed || info->IsDownload() ||
+ //
+ // TODO(davidben): Unify IsDownload() and is_stream(). Several places need to
+ // check for both and remembering about streams is error-prone.
+ if (!swap_needed || info->IsDownload() || info->is_stream() ||
(response->head.headers.get() &&
response->head.headers->response_code() == 204)) {
return next_handler_->OnResponseStarted(request_id, response, defer);
« no previous file with comments | « content/browser/loader/buffered_resource_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698