Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issue 1609993002: Mark ForeignCode as isSafeForElimination when it has no effects or exceptions. (Closed)

Created:
4 years, 11 months ago by sra1
Modified:
4 years, 11 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark ForeignCode as isSafeForElimination when it has no effects or exceptions. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/94c08cfc2798a58c89d62b4fe3feacc98f6d1941

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
4 years, 11 months ago (2016-01-20 02:29:16 UTC) #2
asgerf
CL description: effect *or* exceptions. LGTM
4 years, 11 months ago (2016-01-20 04:17:20 UTC) #3
sra1
4 years, 11 months ago (2016-01-20 15:40:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
94c08cfc2798a58c89d62b4fe3feacc98f6d1941 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698