Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 1609983003: Reland of Untouch out of bound pixels for CopyTexSubImage2D (Closed)

Created:
4 years, 11 months ago by Zhenyao Mo
Modified:
4 years, 11 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Untouch out of bound pixels for CopyTexSubImage2D (patchset #1 id:1 of https://codereview.chromium.org/1612473002/ ) Reason for revert: Reland the reverted CL because the failing layout test has been removed in https://codereview.chromium.org/1601093008/ Original issue's description: > Revert of Untouch out of bound pixels for CopyTexSubImage2D (patchset #4 id:60001 of https://codereview.chromium.org/1586053002/ ) > > Reason for revert: > This change breaks blink layout test fast/canvas/webgl/uninitialized-test.html > Example of a failed run: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/59669 > > Original issue's description: > > Untouch out of bound pixels for CopyTexSubImage2D > > > > CopyTexSubImage2D is defined not to touch the corresponding destination > > range for any pixel outside the bound framebuffer. This CL removes code > > which wrongly clears subregion of destination texture. > > > > BUG=577357 > > > > Committed: https://crrev.com/98bcf19d91d046e9e04d820d9a8479e07b27834a > > Cr-Commit-Position: refs/heads/master@{#370332} > > TBR=kbr@chromium.org,zmo@chromium.org,bajones@chromium.org,yunchao.he@intel.com,qiankun.miao@intel.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=577357 > > Committed: https://crrev.com/6386e103ff7570695c27c7a9a69c4f21e74f3fa3 > Cr-Commit-Position: refs/heads/master@{#370401} TBR=kbr@chromium.org,bajones@chromium.org,yunchao.he@intel.com,qiankun.miao@intel.com,junov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=577357 Committed: https://crrev.com/a2f4b60c8ce0ae9fce9faf1dc63bed525280cb8a Cr-Commit-Position: refs/heads/master@{#370475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -27 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +7 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Zhenyao Mo
Created Reland of Untouch out of bound pixels for CopyTexSubImage2D
4 years, 11 months ago (2016-01-20 20:21:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1609983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1609983003/1
4 years, 11 months ago (2016-01-20 20:21:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 20:23:34 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 20:24:58 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2f4b60c8ce0ae9fce9faf1dc63bed525280cb8a
Cr-Commit-Position: refs/heads/master@{#370475}

Powered by Google App Engine
This is Rietveld 408576698