Chromium Code Reviews
DescriptionReland of Untouch out of bound pixels for CopyTexSubImage2D (patchset #1 id:1 of https://codereview.chromium.org/1612473002/ )
Reason for revert:
Reland the reverted CL because the failing layout test has been removed in https://codereview.chromium.org/1601093008/
Original issue's description:
> Revert of Untouch out of bound pixels for CopyTexSubImage2D (patchset #4 id:60001 of https://codereview.chromium.org/1586053002/ )
>
> Reason for revert:
> This change breaks blink layout test fast/canvas/webgl/uninitialized-test.html
> Example of a failed run: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/59669
>
> Original issue's description:
> > Untouch out of bound pixels for CopyTexSubImage2D
> >
> > CopyTexSubImage2D is defined not to touch the corresponding destination
> > range for any pixel outside the bound framebuffer. This CL removes code
> > which wrongly clears subregion of destination texture.
> >
> > BUG=577357
> >
> > Committed: https://crrev.com/98bcf19d91d046e9e04d820d9a8479e07b27834a
> > Cr-Commit-Position: refs/heads/master@{#370332}
>
> TBR=kbr@chromium.org,zmo@chromium.org,bajones@chromium.org,yunchao.he@intel.com,qiankun.miao@intel.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=577357
>
> Committed: https://crrev.com/6386e103ff7570695c27c7a9a69c4f21e74f3fa3
> Cr-Commit-Position: refs/heads/master@{#370401}
TBR=kbr@chromium.org,bajones@chromium.org,yunchao.he@intel.com,qiankun.miao@intel.com,junov@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=577357
Committed: https://crrev.com/a2f4b60c8ce0ae9fce9faf1dc63bed525280cb8a
Cr-Commit-Position: refs/heads/master@{#370475}
Patch Set 1 #
Messages
Total messages: 5 (1 generated)
|
|||||||||||||||||||