Precompilation: drop Field objects unless they are an entry point or referenced from a constant poo…

Precompilation: drop Field objects unless they are an entry point or referenced from a constant pool.

Don't record stores when deserializing message snapshots when field guards aren't enabled.

precompiled dart2js x64 23232236 -> 23068873 (-0.70%)

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/bbee77d59127263f84b81837ff79edd2200be881

[rmacnak, 2016-01-20 01:53:12]

Description was changed from

==========
Precompilation: drop Field objects unless they are an entry point or referenced
from a constant pool.

Don't record stores when deserializing message snapshots when field guards
aren't enabled.
==========

to

==========
Precompilation: drop Field objects unless they are an entry point or referenced
from a constant pool.

Don't record stores when deserializing message snapshots when field guards
aren't enabled.

precompiled dart2js x64 23232236 -> 23068873 (-0.70%)
==========

[rmacnak, 2016-01-20 01:54:14]

rmacnak@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-01-20 16:43:51]

lgtm

https://codereview.chromium.org/1609983002/diff/20001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1609983002/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:991: if (fields.Length() > 0) {
s/fields/retained_fields/

https://codereview.chromium.org/1609983002/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:992: fields = Array::New(retained_fields.Length(),
Heap::kOld);
Use Array::MakeArray here?

[rmacnak, 2016-01-20 18:41:57]

https://codereview.chromium.org/1609983002/diff/20001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1609983002/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:991: if (fields.Length() > 0) {
On 2016/01/20 16:43:51, Florian Schneider wrote:
> s/fields/retained_fields/

Done.

https://codereview.chromium.org/1609983002/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:992: fields = Array::New(retained_fields.Length(),
Heap::kOld);
On 2016/01/20 16:43:51, Florian Schneider wrote:
> Use Array::MakeArray here?

Done, here and above.

[rmacnak, 2016-01-20 18:44:02]

Description was changed from

==========
Precompilation: drop Field objects unless they are an entry point or referenced
from a constant pool.

Don't record stores when deserializing message snapshots when field guards
aren't enabled.

precompiled dart2js x64 23232236 -> 23068873 (-0.70%)
==========

to

==========
Precompilation: drop Field objects unless they are an entry point or referenced
from a constant pool.

Don't record stores when deserializing message snapshots when field guards
aren't enabled.

precompiled dart2js x64 23232236 -> 23068873 (-0.70%)

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/bbee77d59127263f84b81837ff79edd2200be881
==========

[rmacnak, 2016-01-20 18:44:03]

Committed patchset #3 (id:40001) manually as
bbee77d59127263f84b81837ff79edd2200be881 (presubmit successful).