Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/components/HandlerRegistry.js

Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 function save(forceSaveAs) 142 function save(forceSaveAs)
143 { 143 {
144 if (contentProvider instanceof WebInspector.UISourceCode) { 144 if (contentProvider instanceof WebInspector.UISourceCode) {
145 var uiSourceCode = /** @type {!WebInspector.UISourceCode} */ (co ntentProvider); 145 var uiSourceCode = /** @type {!WebInspector.UISourceCode} */ (co ntentProvider);
146 if (forceSaveAs) 146 if (forceSaveAs)
147 uiSourceCode.saveAs(); 147 uiSourceCode.saveAs();
148 else 148 else
149 uiSourceCode.commitWorkingCopy(); 149 uiSourceCode.commitWorkingCopy();
150 return; 150 return;
151 } 151 }
152 contentProvider.requestContent(doSave.bind(null, forceSaveAs)); 152 contentProvider.requestContent().then(doSave.bind(null, forceSaveAs) );
153 } 153 }
154 154
155 contextMenu.appendSeparator(); 155 contextMenu.appendSeparator();
156 contextMenu.appendItem(WebInspector.UIString("Save"), save.bind(null, fa lse)); 156 contextMenu.appendItem(WebInspector.UIString("Save"), save.bind(null, fa lse));
157 157
158 if (contentProvider instanceof WebInspector.UISourceCode) { 158 if (contentProvider instanceof WebInspector.UISourceCode) {
159 var uiSourceCode = /** @type {!WebInspector.UISourceCode} */ (conten tProvider); 159 var uiSourceCode = /** @type {!WebInspector.UISourceCode} */ (conten tProvider);
160 if (uiSourceCode.project().type() !== WebInspector.projectTypes.File System && uiSourceCode.project().type() !== WebInspector.projectTypes.Snippets) 160 if (uiSourceCode.project().type() !== WebInspector.projectTypes.File System && uiSourceCode.project().type() !== WebInspector.projectTypes.Snippets)
161 contextMenu.appendItem(WebInspector.UIString.capitalize("Save ^a s..."), save.bind(null, true)); 161 contextMenu.appendItem(WebInspector.UIString.capitalize("Save ^a s..."), save.bind(null, true));
162 } 162 }
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 316
317 var handlerSelector = new WebInspector.HandlerSelector(WebInspector.open AnchorLocationRegistry); 317 var handlerSelector = new WebInspector.HandlerSelector(WebInspector.open AnchorLocationRegistry);
318 return WebInspector.SettingsUI.createCustomSetting(WebInspector.UIString ("Link handling:"), handlerSelector.element); 318 return WebInspector.SettingsUI.createCustomSetting(WebInspector.UIString ("Link handling:"), handlerSelector.element);
319 } 319 }
320 } 320 }
321 321
322 /** 322 /**
323 * @type {!WebInspector.HandlerRegistry} 323 * @type {!WebInspector.HandlerRegistry}
324 */ 324 */
325 WebInspector.openAnchorLocationRegistry; 325 WebInspector.openAnchorLocationRegistry;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698