Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaseline Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 120
121 get textEditor() 121 get textEditor()
122 { 122 {
123 return this._textEditor; 123 return this._textEditor;
124 }, 124 },
125 125
126 _ensureContentLoaded: function() 126 _ensureContentLoaded: function()
127 { 127 {
128 if (!this._contentRequested) { 128 if (!this._contentRequested) {
129 this._contentRequested = true; 129 this._contentRequested = true;
130 this._contentProvider.requestContent(this.setContent.bind(this)); 130 this._contentProvider.requestContent().then(this.setContent.bind(thi s));
131 } 131 }
132 }, 132 },
133 133
134 /** 134 /**
135 * @param {number} line 0-based 135 * @param {number} line 0-based
136 * @param {number=} column 136 * @param {number=} column
137 * @param {boolean=} shouldHighlight 137 * @param {boolean=} shouldHighlight
138 */ 138 */
139 revealPosition: function(line, column, shouldHighlight) 139 revealPosition: function(line, column, shouldHighlight)
140 { 140 {
(...skipping 537 matching lines...) Expand 10 before | Expand all | Expand 10 after
678 /** 678 /**
679 * @override 679 * @override
680 * @param {?WebInspector.TextRange} from 680 * @param {?WebInspector.TextRange} from
681 * @param {?WebInspector.TextRange} to 681 * @param {?WebInspector.TextRange} to
682 */ 682 */
683 onJumpToPosition: function(from, to) 683 onJumpToPosition: function(from, to)
684 { 684 {
685 this._sourceFrame.onJumpToPosition(from, to); 685 this._sourceFrame.onJumpToPosition(from, to);
686 } 686 }
687 } 687 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698