Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Unified Diff: win_toolchain/package_from_installed.py

Issue 1609933004: Skip include\ucrt on VS 2013 packages (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Remove pointless .replace() call Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: win_toolchain/package_from_installed.py
diff --git a/win_toolchain/package_from_installed.py b/win_toolchain/package_from_installed.py
index a178864a1633a15cb17fad9f9b379f72ca4d73ca..c71de3dab9f78809f6e2f5310397c732415729e7 100644
--- a/win_toolchain/package_from_installed.py
+++ b/win_toolchain/package_from_installed.py
@@ -187,12 +187,14 @@ def GenerateSetEnvCmd(target_dir):
'set VCINSTALLDIR=%~dp0..\\..\\VC\\\n'
'set PATH=%~dp0..\\..\\Common7\\IDE;%PATH%\n'
'set INCLUDE=%~dp0..\\..\\win_sdk\\Include\\WINVERSION\\um;'
- '%~dp0..\\..\\win_sdk\\Include\\WINVERSION\\shared;'
- '%~dp0..\\..\\win_sdk\\Include\\WINVERSION\\winrt;'
- '%~dp0..\\..\\win_sdk\\Include\\WINVERSION\\ucrt;' # VS 2015
- '%~dp0..\\..\\VC\\include;'
- '%~dp0..\\..\\VC\\atlmfc\\include\n'
- 'if "%1"=="/x64" goto x64\n'.replace('WINVERSION', WIN_VERSION))
brucedawson 2016/02/03 18:56:51 Ah crap. I accidentally deleted this whole line wh
+ '%~dp0..\\..\\win_sdk\\Include\\WINVERSION\\shared;'
+ '%~dp0..\\..\\win_sdk\\Include\\WINVERSION\\winrt;'.replace(
+ 'WINVERSION', WIN_VERSION))
+ if VS_VERSION == '2015':
+ f.write('%~dp0..\\..\\win_sdk\\Include\\WINVERSION\\ucrt;'.replace(
+ 'WINVERSION', WIN_VERSION))
+ f.write('%~dp0..\\..\\VC\\include;'
+ '%~dp0..\\..\\VC\\atlmfc\\include\n')
# x86. Always use amd64_x86 cross, not x86 on x86.
f.write('set PATH=%~dp0..\\..\\win_sdk\\bin\\x86;'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698