chrome/browser/extensions/api/webstore_private/webstore_private_api.cc - Issue 1609923002: Fix remaining incompatibilities between scoped_ptr and unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 1609923002: Fix remaining incompatibilities between scoped_ptr and unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/gcd_private/privet_v3_session.cc ('k') | chrome/browser/profile_resetter/brandcode_config_fetcher.h » ('j') | media/base/bind_to_current_loop_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

index c88e10e6a6df3763e58c6e6ddf81bb569b7e03f0..7ee73f47813b2d5c75e3771cc781631fa07cc120 100644

--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

@@ -332,11 +332,11 @@ void WebstorePrivateBeginInstallWithManifest3Function::HandleInstallProceed() {

WebstoreInstaller::Approval::CreateWithNoInstallPrompt(

chrome_details_.GetProfile(), details().id,

std::move(parsed_manifest_), false));

- approval->use_app_installed_bubble = details().app_install_bubble;

- approval->enable_launcher = details().enable_launcher;

+ approval->use_app_installed_bubble = !!details().app_install_bubble;

+ approval->enable_launcher = !!details().enable_launcher;

// If we are enabling the launcher, we should not show the app list in order

// to train the user to open it themselves at least once.

- approval->skip_post_install_ui = details().enable_launcher;

+ approval->skip_post_install_ui = !!details().enable_launcher;

approval->dummy_extension = dummy_extension_.get();

approval->installing_icon = gfx::ImageSkia::CreateFrom1xBitmap(icon_);

if (details().authuser)