GYP changes and scripts for compiling Skia for ChromeOS

GYP Changes and Scripts for Compiling Skia for ChromeOS

For now, this requires having a complete ChromeOS checkout.

R=djsollen@google.com

Committed: https://code.google.com/p/skia/source/detail?r=9505

[borenet, 2013-06-07 19:29:27]

I tried to "svn cp" where I could, but I think that might have actually made
this harder to review...

https://codereview.chromium.org/16099011/diff/1/gyp/chromeos_deps.gyp
File gyp/chromeos_deps.gyp (right):

https://codereview.chromium.org/16099011/diff/1/gyp/chromeos_deps.gyp#newcode1
gyp/chromeos_deps.gyp:1: # This GYP file stores the dependencies necessary to
build Skia on the Chrome OS
"svn cp" from gyp/android_deps.gyp.

https://codereview.chromium.org/16099011/diff/1/gyp/common_variables.gypi
File gyp/common_variables.gypi (right):

https://codereview.chromium.org/16099011/diff/1/gyp/common_variables.gypi#new...
gyp/common_variables.gypi:130: 'skia_cros_target%': '',
Should add verification to make sure this gets defined.

https://codereview.chromium.org/16099011/diff/1/platform_tools/chromeos/bin/c...
File platform_tools/chromeos/bin/chromeos_make (right):

https://codereview.chromium.org/16099011/diff/1/platform_tools/chromeos/bin/c...
platform_tools/chromeos/bin/chromeos_make:10:
#TOOLCHAIN_DIR=${SCRIPT_DIR}/../toolchains
Delete this.

[djsollen, 2013-06-07 20:32:32]

https://codereview.chromium.org/16099011/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/16099011/diff/1/DEPS#newcode28
DEPS:28: "platform_tools/chromeos/third_party/externals/gif":
"https://android.googlesource.com/platform/external/giflib.git",
are you sure we want to be pulling android's copy?

https://codereview.chromium.org/16099011/diff/1/platform_tools/chromeos/bin/c...
File platform_tools/chromeos/bin/chromeos_setup.sh (right):

https://codereview.chromium.org/16099011/diff/1/platform_tools/chromeos/bin/c...
platform_tools/chromeos/bin/chromeos_setup.sh:18: DEFINES="${DEFINES}
skia_warnings_as_errors=0"
is this causing problems? We should at least have a TODO to remove this.

[borenet, 2013-06-07 20:53:03]

https://codereview.chromium.org/16099011/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/16099011/diff/1/DEPS#newcode28
DEPS:28: "platform_tools/chromeos/third_party/externals/gif":
"https://android.googlesource.com/platform/external/giflib.git",
On 2013/06/07 20:32:32, djsollen wrote:
> are you sure we want to be pulling android's copy?

I can pull it from elsewhere if that makes more sense.  Do we expect it to be
different?

https://codereview.chromium.org/16099011/diff/1/platform_tools/chromeos/bin/c...
File platform_tools/chromeos/bin/chromeos_setup.sh (right):

https://codereview.chromium.org/16099011/diff/1/platform_tools/chromeos/bin/c...
platform_tools/chromeos/bin/chromeos_setup.sh:18: DEFINES="${DEFINES}
skia_warnings_as_errors=0"
On 2013/06/07 20:32:32, djsollen wrote:
> is this causing problems? We should at least have a TODO to remove this.

The arm toolchain is throwing lots of "mangling of va_list has changed"
warnings.  There's a suppression, but it covers other warnings too.

[djsollen, 2013-06-10 13:06:47]

lgtm with my nits and your changes

https://codereview.chromium.org/16099011/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/16099011/diff/1/DEPS#newcode28
DEPS:28: "platform_tools/chromeos/third_party/externals/gif":
"https://android.googlesource.com/platform/external/giflib.git",
On 2013/06/07 20:53:03, borenet wrote:
> On 2013/06/07 20:32:32, djsollen wrote:
> > are you sure we want to be pulling android's copy?
> 
> I can pull it from elsewhere if that makes more sense.  Do we expect it to be
> different?

The android copy isn't currently different, but thate is nothing keeping it from
being different.  That being said we can just go with it for now as I don't
anticipate it changing.

https://codereview.chromium.org/16099011/diff/1/platform_tools/chromeos/bin/c...
File platform_tools/chromeos/bin/chromeos_setup.sh (right):

https://codereview.chromium.org/16099011/diff/1/platform_tools/chromeos/bin/c...
platform_tools/chromeos/bin/chromeos_setup.sh:18: DEFINES="${DEFINES}
skia_warnings_as_errors=0"
Just put a big TODO here then explaining

On 2013/06/07 20:53:03, borenet wrote:
> On 2013/06/07 20:32:32, djsollen wrote:
> > is this causing problems? We should at least have a TODO to remove this.
> 
> The arm toolchain is throwing lots of "mangling of va_list has changed"
> warnings.  There's a suppression, but it covers other warnings too.

[borenet, 2013-06-11 13:25:42]

Uploaded patch set 3.

https://codereview.chromium.org/16099011/diff/1/gyp/common_variables.gypi
File gyp/common_variables.gypi (right):

https://codereview.chromium.org/16099011/diff/1/gyp/common_variables.gypi#new...
gyp/common_variables.gypi:130: 'skia_cros_target%': '',
On 2013/06/07 19:29:27, borenet wrote:
> Should add verification to make sure this gets defined.

Done.

https://codereview.chromium.org/16099011/diff/1/platform_tools/chromeos/bin/c...
File platform_tools/chromeos/bin/chromeos_make (right):

https://codereview.chromium.org/16099011/diff/1/platform_tools/chromeos/bin/c...
platform_tools/chromeos/bin/chromeos_make:10:
#TOOLCHAIN_DIR=${SCRIPT_DIR}/../toolchains
On 2013/06/07 19:29:27, borenet wrote:
> Delete this.

Done.

https://codereview.chromium.org/16099011/diff/1/platform_tools/chromeos/bin/c...
File platform_tools/chromeos/bin/chromeos_setup.sh (right):

https://codereview.chromium.org/16099011/diff/1/platform_tools/chromeos/bin/c...
platform_tools/chromeos/bin/chromeos_setup.sh:18: DEFINES="${DEFINES}
skia_warnings_as_errors=0"
On 2013/06/10 13:06:47, djsollen wrote:
> Just put a big TODO here then explaining
> 
> On 2013/06/07 20:53:03, borenet wrote:
> > On 2013/06/07 20:32:32, djsollen wrote:
> > > is this causing problems? We should at least have a TODO to remove this.
> > 
> > The arm toolchain is throwing lots of "mangling of va_list has changed"
> > warnings.  There's a suppression, but it covers other warnings too.
> 

Done.

https://codereview.chromium.org/16099011/diff/35001/gyp/common.gypi
File gyp/common.gypi (right):

https://codereview.chromium.org/16099011/diff/35001/gyp/common.gypi#newcode45
gyp/common.gypi:45: }],
I added these checks, but none of these seem to actually cause any errors!

[djsollen, 2013-06-11 15:50:13]

lgtm, but are you sure you are brave enough to commit something else to the
tree?

[borenet, 2013-06-11 15:51:24]

On 2013/06/11 15:50:13, djsollen wrote:
> lgtm, but are you sure you are brave enough to commit something else to the
> tree?

Brave, or stupid?

[borenet, 2013-06-11 15:52:38]

Committed patchset #3 manually as r9505 (presubmit successful).

[tfarina, 2013-07-13 03:56:56]

https://codereview.chromium.org/16099011/diff/35001/platform_tools/chromeos/g...
File platform_tools/chromeos/gyp/dependencies.gypi (right):

https://codereview.chromium.org/16099011/diff/35001/platform_tools/chromeos/g...
platform_tools/chromeos/gyp/dependencies.gypi:11: 'target_name': 'gif',
how this is compiling on Linux?

$ ninja -C out/Debug

[6/571] CXX obj/src/images/images.SkImageDecoder_libgif.o
FAILED: clang++ -MMD -MF obj/src/images/images.SkImageDecoder_libgif.o.d
-DSK_GAMMA_SRGB -DSK_GAMMA_APPLY_TO_A8 -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=1
-DSK_SCALAR_IS_FLOAT -DSK_CAN_USE_FLOAT -DSK_SUPPORT_GPU=1 -DSK_SAMPLES_FOR_X
-DSK_BUILD_FOR_UNIX -DSK_USE_POSIX_THREADS -DSK_DEBUG -DGR_DEBUG=1
-DSK_DEVELOPER=1 -I/usr/include/freetype2 -I../../include/config
-I../../include/core -I../../include/images -I../../include/lazy
-I../../src/core -I../../src/image -I../../third_party/externals/libjpeg
-I../../third_party/externals/libwebp/src -I../../include/utils -Werror -Wall
-Wextra -Wno-unused-parameter -Wno-c++11-extensions -m64 -g   -c
../../src/images/SkImageDecoder_libgif.cpp -o
obj/src/images/images.SkImageDecoder_libgif.o
../../src/images/SkImageDecoder_libgif.cpp:17:10: fatal error: 'gif_lib.h' file
not found
#include "gif_lib.h"
         ^
1 error generated.

[djsollen, 2013-07-15 11:59:43]

https://codereview.chromium.org/16099011/diff/35001/platform_tools/chromeos/g...
File platform_tools/chromeos/gyp/dependencies.gypi (right):

https://codereview.chromium.org/16099011/diff/35001/platform_tools/chromeos/g...
platform_tools/chromeos/gyp/dependencies.gypi:11: 'target_name': 'gif',
This file is only related to ChromeOS.  For that standard linux build see
trunk/gyp/images.gyp and you will find that on linux we expect the host OS to
have installed gifn development libs and we just link using -lgif.