Added old data space allocation infrastructure for pretenuring.

Added old data space allocation infrastructure for pretenuring.


BUG=

Committed: https://code.google.com/p/v8/source/detail?r=14843

[Hannes Payer (out of office), 2013-05-27 16:04:27]

I will add a test case as soon as BuildFastLiterals supports hybrid pretenuring
(allocation in old data space and old pointer space).

[mvstanton, 2013-05-28 07:11:11]

I see one spot for some refactoring but looks good. lgtm.

https://codereview.chromium.org/16099004/diff/6001/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/16099004/diff/6001/src/runtime.cc#newcode9293
src/runtime.cc:9293: return maybe_allocation;
Aside from the assert involving MaxNewSpaceAllocationSize() and the pointer
(new_space(), old_pointer_space(), old_data_space()), these three runtime
allocation methods are the same. Could the assert be placed in
Runtime_AllocateInNewSpace, but have all the other code in a common method that
takes a Space pointer?

[Hannes Payer (out of office), 2013-05-28 09:06:06]

https://codereview.chromium.org/16099004/diff/6001/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/16099004/diff/6001/src/runtime.cc#newcode9293
src/runtime.cc:9293: return maybe_allocation;
On 2013/05/28 07:11:11, mvstanton wrote:
> Aside from the assert involving MaxNewSpaceAllocationSize() and the pointer
> (new_space(), old_pointer_space(), old_data_space()), these three runtime
> allocation methods are the same. Could the assert be placed in
> Runtime_AllocateInNewSpace, but have all the other code in a common method
that
> takes a Space pointer?

Thanks for the suggestion. I refactored the code. Moreover
MaxNewSpaceAllocationSize() should be also checked for old data space and old
pointer space allocation. I renamed MaxNewSpaceAllocationSize to
MaxRegularSpaceAllocationSize.

[mvstanton, 2013-05-28 09:16:01]

Hey that is awesome. Right on,
--Michael

[Hannes Payer (out of office), 2013-05-28 09:38:39]

Committed patchset #6 manually as r14843 (presubmit successful).