src/compiler/bytecode-graph-builder.cc - Issue 1609893003: [es6] Tail calls support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/bytecode-graph-builder.cc

Issue 1609893003: [es6] Tail calls support. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Support for CS and TF compilers added Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/bytecode-graph-builder.cc

diff --git a/src/compiler/bytecode-graph-builder.cc b/src/compiler/bytecode-graph-builder.cc

index 38a0baf8587e9b9f1698461f5989e79fa99f02d6..b0dd5d4af7d5a8f3417dd8f1b532fcad14bb147e 100644

--- a/src/compiler/bytecode-graph-builder.cc

+++ b/src/compiler/bytecode-graph-builder.cc

@@ -1196,6 +1196,7 @@ void BytecodeGraphBuilder::BuildCall(

size_t arg_count = iterator.GetCountOperand(2);

VectorSlotPair feedback = CreateVectorSlotPair(iterator.GetIndexOperand(3));

+ // TODO(ishell): provide correct tail_call_mode value to CallFunction.

const Operator* call = javascript()->CallFunction(

arg_count + 2, language_mode(), feedback, receiver_hint);

Node* value = ProcessCallArguments(call, callee, receiver, arg_count + 2);