src/full-codegen/x64/full-codegen-x64.cc - Issue 1609893003: [es6] Tail calls support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 1609893003: [es6] Tail calls support. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/x64/full-codegen-x64.cc

diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc

index 6d3d1b435b1ea495dbd59c0aa2db422fa7b571c4..e0848775eeb1e74c6b49db4cc8b3c9f8796cbdbb 100644

--- a/src/full-codegen/x64/full-codegen-x64.cc

+++ b/src/full-codegen/x64/full-codegen-x64.cc

@@ -2742,7 +2742,10 @@ void FullCodeGenerator::EmitCall(Call* expr, ConvertReceiverMode mode) {

PrepareForBailoutForId(expr->CallId(), NO_REGISTERS);

SetCallPosition(expr);

- Handle<Code> ic = CodeFactory::CallIC(isolate(), arg_count, mode).code();

+ TailCallMode tail_call_mode =

+ expr->is_tail() ? TailCallMode::kAllow : TailCallMode::kDisallow;

+ Handle<Code> ic =

+ CodeFactory::CallIC(isolate(), arg_count, mode, tail_call_mode).code();

__ Move(rdx, SmiFromSlot(expr->CallFeedbackICSlot()));

__ movp(rdi, Operand(rsp, (arg_count + 1) * kPointerSize));

// Don't assign a type feedback id to the IC, since type feedback is provided