src/crankshaft/x64/lithium-codegen-x64.cc - Issue 1609893003: [es6] Tail calls support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/x64/lithium-codegen-x64.cc

Issue 1609893003: [es6] Tail calls support. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/x64/lithium-codegen-x64.cc

diff --git a/src/crankshaft/x64/lithium-codegen-x64.cc b/src/crankshaft/x64/lithium-codegen-x64.cc

index feb071d848583b55a576c8383017eddfa1327bfd..590544dd9b513899f06a9342097b963b57f7e866 100644

--- a/src/crankshaft/x64/lithium-codegen-x64.cc

+++ b/src/crankshaft/x64/lithium-codegen-x64.cc

@@ -3760,6 +3760,7 @@ void LCodeGen::DoCallFunction(LCallFunction* instr) {

__ Move(vector_register, vector);

__ Move(slot_register, Smi::FromInt(index));

+ // TODO(ishell): propagate correct TailCallMode

Handle<Code> ic =

CodeFactory::CallICInOptimizedCode(isolate(), arity, mode).code();

CallCode(ic, RelocInfo::CODE_TARGET, instr);