Add function tables to asm to wasm

Add function tables to asm to wasm

R=titzer@chromium.org,aseemgarg@chromium.org
BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, asm-wasm.js
LOG=N

Committed: https://crrev.com/6492686241e63cf0ba1ba0f363be79533c86eb72
Cr-Commit-Position: refs/heads/master@{#33421}

[aseemgarg, 2016-01-19 22:51:22]

aseemgarg@chromium.org changed reviewers:
+ bradnelson@chromium.org
- aseemgarg@chromium.org

[bradnelson, 2016-01-20 00:40:52]

lgtm with a test of constant index and a one question.

https://codereview.chromium.org/1609893002/diff/40001/src/typing-asm.cc
File src/typing-asm.cc (right):

https://codereview.chromium.org/1609893002/diff/40001/src/typing-asm.cc#newco...
src/typing-asm.cc:730: // TODO(aseemgarg): Fix the parser and then un-comment
this part
You can put my name on this todo if you like (or keep yours :-).

https://codereview.chromium.org/1609893002/diff/60001/src/wasm/encoder.cc
File src/wasm/encoder.cc (right):

https://codereview.chromium.org/1609893002/diff/60001/src/wasm/encoder.cc#new...
src/wasm/encoder.cc:370: if (a->return_count() > b->return_count()) return
false;
Ah, yeah, that would rather throw a wrench in things :-)

https://codereview.chromium.org/1609893002/diff/60001/test/mjsunit/wasm/asm-w...
File test/mjsunit/wasm/asm-wasm.js (right):

https://codereview.chromium.org/1609893002/diff/60001/test/mjsunit/wasm/asm-w...
test/mjsunit/wasm/asm-wasm.js:908: return funBin[fun_id&3](arg1, arg2)|0;
Given the parser eats constant function indexes and that needs special handling,
could we also have a test that checks that case?
Thanks

[aseemgarg, 2016-01-20 00:56:09]

https://codereview.chromium.org/1609893002/diff/40001/src/typing-asm.cc
File src/typing-asm.cc (right):

https://codereview.chromium.org/1609893002/diff/40001/src/typing-asm.cc#newco...
src/typing-asm.cc:730: // TODO(aseemgarg): Fix the parser and then un-comment
this part
On 2016/01/20 00:40:52, bradnelson wrote:
> You can put my name on this todo if you like (or keep yours :-).

Done.

https://codereview.chromium.org/1609893002/diff/60001/test/mjsunit/wasm/asm-w...
File test/mjsunit/wasm/asm-wasm.js (right):

https://codereview.chromium.org/1609893002/diff/60001/test/mjsunit/wasm/asm-w...
test/mjsunit/wasm/asm-wasm.js:908: return funBin[fun_id&3](arg1, arg2)|0;
On 2016/01/20 00:40:52, bradnelson wrote:
> Given the parser eats constant function indexes and that needs special
handling,
> could we also have a test that checks that case?
> Thanks

Added that above TestFunctionTableSimple

[bradnelson, 2016-01-20 00:57:01]

https://codereview.chromium.org/1609893002/diff/60001/test/mjsunit/wasm/asm-w...
File test/mjsunit/wasm/asm-wasm.js (right):

https://codereview.chromium.org/1609893002/diff/60001/test/mjsunit/wasm/asm-w...
test/mjsunit/wasm/asm-wasm.js:908: return funBin[fun_id&3](arg1, arg2)|0;
On 2016/01/20 00:40:52, bradnelson wrote:
> Given the parser eats constant function indexes and that needs special
handling,
> could we also have a test that checks that case?
> Thanks

Doh, missed the test above, though actually might be good to check it works with
a table greater than size 1?

[aseemgarg, 2016-01-20 01:15:17]

On 2016/01/20 00:57:01, bradnelson wrote:
>
https://codereview.chromium.org/1609893002/diff/60001/test/mjsunit/wasm/asm-w...
> File test/mjsunit/wasm/asm-wasm.js (right):
> 
>
https://codereview.chromium.org/1609893002/diff/60001/test/mjsunit/wasm/asm-w...
> test/mjsunit/wasm/asm-wasm.js:908: return funBin[fun_id&3](arg1, arg2)|0;
> On 2016/01/20 00:40:52, bradnelson wrote:
> > Given the parser eats constant function indexes and that needs special
> handling,
> > could we also have a test that checks that case?
> > Thanks
> 
> Doh, missed the test above, though actually might be good to check it works
with
> a table greater than size 1?

done

[bradnelson, 2016-01-20 13:24:00]

lgtm

[aseemgarg, 2016-01-20 19:30:53]

The CQ bit was checked by aseemgarg@chromium.org

[commit-bot: I haz the power, 2016-01-20 19:30:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1609893002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1609893002/100001

[commit-bot: I haz the power, 2016-01-20 19:36:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 19:36:26]

Try jobs failed on following builders:
  v8_win_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/1697)

[aseemgarg, 2016-01-20 20:28:28]

The CQ bit was checked by aseemgarg@chromium.org

[aseemgarg, 2016-01-20 20:28:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@chromium.org
Link to the patchset: https://codereview.chromium.org/1609893002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-01-20 20:28:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1609893002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1609893002/120001

[commit-bot: I haz the power, 2016-01-20 20:31:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 20:31:31]

Try jobs failed on following builders:
  v8_win_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/1700)

[aseemgarg, 2016-01-20 23:02:34]

The CQ bit was checked by aseemgarg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 23:02:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1609893002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1609893002/140001

[commit-bot: I haz the power, 2016-01-20 23:31:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 23:31:05]

Dry run: This issue passed the CQ dry run.

[bradnelson, 2016-01-20 23:32:46]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2016-01-20 23:32:46]

lgtm

[bradnelson, 2016-01-20 23:32:57]

The CQ bit was unchecked by bradnelson@chromium.org

[commit-bot: I haz the power, 2016-01-20 23:32:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1609893002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1609893002/140001

[bradnelson, 2016-01-20 23:35:11]

Description was changed from

==========
Add function tables to asm to wasm

R=titzer@chromium.org,aseemgarg@chromium.org
BUG=
==========

to

==========
Add function tables to asm to wasm

R=titzer@chromium.org,aseemgarg@chromium.org
BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, asm-wasm.js
LOG=N
==========

[bradnelson, 2016-01-20 23:35:19]

The CQ bit was checked by bradnelson@chromium.org

[commit-bot: I haz the power, 2016-01-20 23:35:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1609893002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1609893002/140001

[commit-bot: I haz the power, 2016-01-20 23:36:47]

Description was changed from

==========
Add function tables to asm to wasm

R=titzer@chromium.org,aseemgarg@chromium.org
BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, asm-wasm.js
LOG=N
==========

to

==========
Add function tables to asm to wasm

R=titzer@chromium.org,aseemgarg@chromium.org
BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, asm-wasm.js
LOG=N
==========

[commit-bot: I haz the power, 2016-01-20 23:36:48]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-01-20 23:37:46]

Description was changed from

==========
Add function tables to asm to wasm

R=titzer@chromium.org,aseemgarg@chromium.org
BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, asm-wasm.js
LOG=N
==========

to

==========
Add function tables to asm to wasm

R=titzer@chromium.org,aseemgarg@chromium.org
BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, asm-wasm.js
LOG=N

Committed: https://crrev.com/6492686241e63cf0ba1ba0f363be79533c86eb72
Cr-Commit-Position: refs/heads/master@{#33421}
==========

[commit-bot: I haz the power, 2016-01-20 23:37:47]

Patchset 8 (id:??) landed as
https://crrev.com/6492686241e63cf0ba1ba0f363be79533c86eb72
Cr-Commit-Position: refs/heads/master@{#33421}