Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1609873003: remove fragile assert (Closed)

Created:
4 years, 11 months ago by reed1
Modified:
4 years, 11 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove fragile assert The assert basically wants the following to always be true (but it aint) floor(int + 0.5 + float) == floor(0.5 + float) + int ... where int + 0.5 happens first, and then we add the float. BUG=skia:4825 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1609873003 Committed: https://skia.googlesource.com/skia/+/bf361d3ba2ed9cd5a3da827ca0f7ef0d44b50410

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M src/core/SkBitmapProcState.cpp View 1 2 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1609873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1609873003/1
4 years, 11 months ago (2016-01-20 15:37:34 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-20 15:48:45 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1609873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1609873003/20001
4 years, 11 months ago (2016-01-20 15:56:54 UTC) #8
reed1
4 years, 11 months ago (2016-01-20 15:57:11 UTC) #10
f(malita)
lgtm
4 years, 11 months ago (2016-01-20 16:00:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1609873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1609873003/20001
4 years, 11 months ago (2016-01-20 16:05:26 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 16:12:05 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/bf361d3ba2ed9cd5a3da827ca0f7ef0d44b50410

Powered by Google App Engine
This is Rietveld 408576698