Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: tool/input_sdk/lib/js/dart2js/js_dart2js.dart

Issue 1609843002: partial fix for #414, avoid dcall in _convertToDart (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/codegen/expect/collection/wrappers.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/lib/js/dart2js/js_dart2js.dart
diff --git a/tool/input_sdk/lib/js/dart2js/js_dart2js.dart b/tool/input_sdk/lib/js/dart2js/js_dart2js.dart
index 08449bd25534f3fc41a05a851a1f618687327f81..da084509b49496b3d1c0be2c6fe51916304039cc 100644
--- a/tool/input_sdk/lib/js/dart2js/js_dart2js.dart
+++ b/tool/input_sdk/lib/js/dart2js/js_dart2js.dart
@@ -475,13 +475,12 @@ dynamic _wrapDartFunction(f) {
// converts a Dart object to a reference to a native JS object
// which might be a DartObject JS->Dart proxy
-Object _convertToDart(o, [bool isBrowserType(x)]) {
- if (isBrowserType == null) isBrowserType = _isBrowserType;
+Object _convertToDart(o) {
if (JS('bool', '# == null', o) ||
JS('bool', 'typeof # == "string"', o) ||
JS('bool', 'typeof # == "number"', o) ||
JS('bool', 'typeof # == "boolean"', o) ||
- isBrowserType(o)) {
+ _isBrowserType(o)) {
return o;
} else if (JS('bool', '# instanceof Date', o)) {
var ms = JS('num', '#.getTime()', o);
« no previous file with comments | « test/codegen/expect/collection/wrappers.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698