Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: lib/runtime/dart/js.js

Issue 1609843002: partial fix for #414, avoid dcall in _convertToDart (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/codegen/expect/collection/wrappers.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/js.js
diff --git a/lib/runtime/dart/js.js b/lib/runtime/dart/js.js
index 7568271f5693a4c0798b61a81b07d789ef508f62..be51648dff610e2a97cf1cacdcd59043edfc62e1 100644
--- a/lib/runtime/dart/js.js
+++ b/lib/runtime/dart/js.js
@@ -343,10 +343,8 @@ dart_library.library('dart/js', null, /* Imports */[
return wrapper;
}
dart.fn(_wrapDartFunction);
- function _convertToDart(o, isBrowserType) {
- if (isBrowserType === void 0) isBrowserType = null;
- if (isBrowserType == null) isBrowserType = _isBrowserType;
- if (o == null || typeof o == "string" || typeof o == "number" || typeof o == "boolean" || dart.notNull(dart.dcall(isBrowserType, o))) {
+ function _convertToDart(o) {
+ if (o == null || typeof o == "string" || typeof o == "number" || typeof o == "boolean" || dart.notNull(_isBrowserType(o))) {
return o;
} else if (o instanceof Date) {
let ms = o.getTime();
@@ -357,7 +355,7 @@ dart_library.library('dart/js', null, /* Imports */[
return _putIfAbsent(_dartProxies, o, _wrapToDart);
}
}
- dart.fn(_convertToDart, core.Object, [dart.dynamic], [dart.functionType(core.bool, [dart.dynamic])]);
+ dart.fn(_convertToDart, core.Object, [dart.dynamic]);
function _wrapToDart(o) {
if (typeof o == "function") {
return new JsFunction._fromJs(o);
« no previous file with comments | « no previous file | test/codegen/expect/collection/wrappers.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698