Issue 1609843002: partial fix for #414, avoid dcall in _convertToDart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1609843002: partial fix for #414, avoid dcall in _convertToDart (Closed)

Created:
4 years, 11 months ago by Jennifer Messerly

Modified:
4 years, 11 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org, devoncarew

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

partial fix for #414, avoid dcall in _convertToDart this doesn't fix the root call, but still, it's nice to clean up this dead code R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/01e0e51a14820c71c97109b87b8f20cc2f752d17

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -11 lines)			Patch
M	lib/runtime/dart/js.js	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	test/codegen/expect/collection/wrappers.txt	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tool/input_sdk/lib/js/dart2js/js_dart2js.dart	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

Jennifer Messerly

4 years, 11 months ago (2016-01-19 20:02:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
01e0e51a14820c71c97109b87b8f20cc2f752d17 (presubmit successful).