third_party/WebKit/Source/core/imagebitmap/ImageBitmapOptions.idl - Issue 1609763002: Implement ImageBitmap options premultiplyAlpha

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/imagebitmap/ImageBitmapOptions.idl

Issue 1609763002: Implement ImageBitmap options premultiplyAlpha (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change to enum instead of boolean Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 enum ImageOrientation { "none", "flipY" };	5 enum ImageOrientation { "none", "flipY" };

	6 enum PremultiplyAlpha { "none", "default" };

6 dictionary ImageBitmapOptions {	7 dictionary ImageBitmapOptions {
	Justin Novosad 2016/02/05 14:46:41 I think this interface should be hidden behind the I think this interface should be hidden behind the experimental flag. The enums as well. Missed this in previous CL xidachen 2016/02/05 16:47:36 Acknowledged. Show quoted text On 2016/02/05 14:46:41, Justin Novosad wrote: > I think this interface should be hidden behind the experimental flag. The enums > as well. Missed this in previous CL Acknowledged.
7 boolean premuiltiplyAlpha;	8 PremultiplyAlpha premultiplyAlpha = "default";

8 ImageOrientation imageOrientation = "none";	9 ImageOrientation imageOrientation = "none";

9 };	10 };

OLD	NEW