Two chagnes to cast socket:

chrome/browser/extensions/api/cast_channel/cast_socket.h

Index: chrome/browser/extensions/api/cast_channel/cast_socket.h
===================================================================
--- chrome/browser/extensions/api/cast_channel/cast_socket.h	(revision 250590)
+++ chrome/browser/extensions/api/cast_channel/cast_socket.h	(working copy)
@@ -16,7 +16,6 @@
 #include "base/threading/thread_checker.h"
 #include "chrome/browser/extensions/api/api_resource.h"
 #include "chrome/browser/extensions/api/api_resource_manager.h"
-#include "chrome/browser/extensions/api/cast_channel/cast_channel.pb.h"

[Wez, 2014/02/12 21:13:16]

How did this make the build flaky? Something including this header that did not
itself depend on the API protos?

[mark a. foltz, 2014/02/12 21:45:02]

The files generated from the IDL included the .pb.h, but didn't depend on the pb
target in GYP.  If the API target is built before the pb target the build
breaks.

[Munjal (Google), 2014/02/12 22:34:36]

It is complicated and hence took me a while to figure out.

So what happens is that generated_api.cc includes all files under extensions/api
that contain EXTENSION_FUNCTION macro defintion. The file generated_api.cc
itself is generated by a python script.

So generated_api.cc includes cast_channel_api.h, which includes cast_socket.h,
which includes cast_channel.pb.h. But cast_channel.pb.h is sometimes not yet
generated from proto buffer before generated_api.cc is compiled.

There are otehr approaches to fix this but this appears to be the cleanest.

 #include "chrome/common/extensions/api/cast_channel.h"
 #include "net/base/completion_callback.h"
 #include "net/base/io_buffer.h"
@@ -37,6 +36,8 @@
 namespace api {
 namespace cast_channel {
 
+class CastMessage;
+
 // Size (in bytes) of the largest allowed message payload on the wire (without
 // the header).
 extern const uint32 kMaxMessageSize;
@@ -261,6 +262,8 @@
 
   // The URL of the peer (cast:// or casts://).
   GURL url_;
+  // String used in log messages for url.

[Wez, 2014/02/12 21:13:16]

Suggest renaming this to |log_prefix_| - you could then do without a
description, but if you prefer to keep one I'd suggest "String containing the
peer's URL, to prefix to all log messages".

[Munjal (Google), 2014/02/12 22:34:36]

Done.

[Munjal (Google), 2014/02/12 22:34:36]

Done.

+  std::string url_log_str_;
   // Delegate to inform of incoming messages and errors.
   Delegate* delegate_;
   // True if receiver authentication should be performed.
@@ -277,7 +280,7 @@
   // The number of bytes in the current message body.
   uint32 current_message_size_;
   // Last message received on the socket.
-  CastMessage current_message_;
+  scoped_ptr<CastMessage> current_message_;
 
   // The NetLog for this service.
   net::NetLog* net_log_;