MD History: Rewrite i18n system using ReplaceTemplateExpressions

MD History: Use $i18n expressions instead of i18n- attributes

This means that localization is performed before data is sent to the
WebUI client. This CL removes almost all existing i18n-template usage.
We still have a small number of more complex strings which are created
in JS which are more difficult to convert to the new system.

BUG=563884
Committed: https://crrev.com/63413cfe062c0c6de3ef56c3b4f1f053976ebb3d
Cr-Commit-Position: refs/heads/master@{#381604}

[tsergeant, 2016-01-31 23:02:42]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[tsergeant, 2016-01-31 23:03:06]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2016-01-31 23:03:07]

PTAL!

[commit-bot: I haz the power, 2016-01-31 23:03:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1609683002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1609683002/60001

[commit-bot: I haz the power, 2016-01-31 23:11:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-31 23:11:36]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tsergeant, 2016-02-01 00:50:35]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-01 00:51:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1609683002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1609683002/80001

[commit-bot: I haz the power, 2016-02-01 02:08:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-01 02:08:25]

Dry run: This issue passed the CQ dry run.

[calamity, 2016-02-01 23:45:33]

lgtm

https://codereview.chromium.org/1609683002/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/md_history_ui.cc (right):

https://codereview.chromium.org/1609683002/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/md_history_ui.cc:50: std::map<std::string, int> router;
Can we make this a const static local?

[tsergeant, 2016-02-02 01:33:10]

tsergeant@chromium.org changed reviewers:
+ dbeam@chromium.org

[tsergeant, 2016-02-02 01:33:10]

+dbeam for a once-over, since this is the new hotness that we're not 100%
familiar with.

https://codereview.chromium.org/1609683002/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/md_history_ui.cc (right):

https://codereview.chromium.org/1609683002/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/md_history_ui.cc:50: std::map<std::string, int> router;
On 2016/02/01 23:45:33, calamity wrote:
> Can we make this a const static local?

Yes, we can.

[dschuyler, 2016-02-02 02:09:57]

On 2016/02/02 01:33:10, tsergeant wrote:
> +dbeam for a once-over, since this is the new hotness that we're not 100%
> familiar with.
> 
>
https://codereview.chromium.org/1609683002/diff/80001/chrome/browser/ui/webui...
> File chrome/browser/ui/webui/md_history_ui.cc (right):
> 
>
https://codereview.chromium.org/1609683002/diff/80001/chrome/browser/ui/webui...
> chrome/browser/ui/webui/md_history_ui.cc:50: std::map<std::string, int>
router;
> On 2016/02/01 23:45:33, calamity wrote:
> > Can we make this a const static local?
> 
> Yes, we can.

Hi, hey thanks for getting started with the $i18n{} use!

I have some (not yet landed) work on doing the replacements in
a general (and centralized) fashion.  That would eliminate
the need for each webui to setup the replacements map and
call the ReplaceTemplateExpressions() (e.g. in md_histor_ui.cc).

Can this CL wait a bit for those improvements or is this
something that needs to go in sooner.  I'm hoping to land
those changes this week.

[tsergeant, 2016-02-02 02:28:29]

Neato! I'm happy for this to get shelved for a couple of weeks while you make
those changes.

[Dan Beam, 2016-02-17 05:08:33]

fyi: https://codereview.chromium.org/1690773003/ should make this a bit easier
for you

[tsergeant, 2016-02-19 03:07:22]

On 2016/02/17 05:08:33, Dan Beam wrote:
> fyi: https://codereview.chromium.org/1690773003/ should make this a bit easier
> for you

Significantly! I'll wait until we land the rest of our existing patches, then go
through and convert it all in one go.

[tsergeant, 2016-03-16 00:42:06]

Description was changed from

==========
MD History: Rewrite i18n system using ReplaceTemplateExpressions

This means that localization is performed before data is sent to the
WebUI client. This CL removes all existing i18n-template usage.

BUG=563884
==========

to

==========
MD History: Use $i18n expressions instead of i18n- attributes

This means that localization is performed before data is sent to the
WebUI client. This CL removes almost all existing i18n-template usage.
We still have a small number of more complex strings which are created
in JS which are more difficult to convert to the new system.

BUG=563884
==========

[tsergeant, 2016-03-16 00:56:10]

calamity: please take a look again. This CL is now a little smaller in scope,
but is enough to unblock the fast-load-time-app-shell patch.

[Dan Beam, 2016-03-16 01:00:52]

soooo, btw: we found that there might be some issues (still) with the current
$i18n{...} thing

right now, if a translator adds quotes (") it could accidentally break out of an
attr="$i18n{thing}".

so we're thinking we add something like $i18n-attr{...} that automagically does
" -> "

[calamity, 2016-03-16 04:04:13]

lgtm

[tsergeant, 2016-03-17 00:21:46]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-03-17 00:22:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1609683002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1609683002/120001

[tsergeant, 2016-03-17 00:28:00]

For the record: We're committing this now to unblock some further work with
optimizing load times, we'll revisit it when there's a better solution for
localizing attributes.

[commit-bot: I haz the power, 2016-03-17 00:28:29]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-03-17 00:29:47]

Description was changed from

==========
MD History: Use $i18n expressions instead of i18n- attributes

This means that localization is performed before data is sent to the
WebUI client. This CL removes almost all existing i18n-template usage.
We still have a small number of more complex strings which are created
in JS which are more difficult to convert to the new system.

BUG=563884
==========

to

==========
MD History: Use $i18n expressions instead of i18n- attributes

This means that localization is performed before data is sent to the
WebUI client. This CL removes almost all existing i18n-template usage.
We still have a small number of more complex strings which are created
in JS which are more difficult to convert to the new system.

BUG=563884

Committed: https://crrev.com/63413cfe062c0c6de3ef56c3b4f1f053976ebb3d
Cr-Commit-Position: refs/heads/master@{#381604}
==========

[commit-bot: I haz the power, 2016-03-17 00:29:49]

Patchset 7 (id:??) landed as
https://crrev.com/63413cfe062c0c6de3ef56c3b4f1f053976ebb3d
Cr-Commit-Position: refs/heads/master@{#381604}