Minor cleanups in UI code that gets host state when webapp is stared

Minor cleanups in UI code that gets host state when webapp is stared

- Previously the UI was getting local host ID before getting state,
but it doesn't make sense when host is not started.
- 2 minor changes in HostList and HostController around host state
initialization.

BUG=149744
R=jamiewalch@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250908

[Jamie, 2014-02-12 23:00:11]

It seems that only the changes to remoting.js are mentioned in the CL
description. Are the others intentional?

https://codereview.chromium.org/160963003/diff/70001/remoting/webapp/host_lis...
File remoting/webapp/host_list.js (right):

https://codereview.chromium.org/160963003/diff/70001/remoting/webapp/host_lis...
remoting/webapp/host_list.js:83: this.localHostState_ =
remoting.HostController.State.UNKNOWN;
I think UNKNOWN is still the right initial value for this, since fetching the
state is an asynchronous operation. What's the downside to initializing it to
UNKNOWN?

https://codereview.chromium.org/160963003/diff/70001/remoting/webapp/remoting.js
File remoting/webapp/remoting.js (right):

https://codereview.chromium.org/160963003/diff/70001/remoting/webapp/remoting...
remoting/webapp/remoting.js:180: * controls that allow to install and enable
Me2Me host.
You've changed the semantics of this methods without changing its name. Perhaps
a better name would be something like isMe2MeInstallable?

[Sergey Ulanov, 2014-02-13 00:44:11]

On 2014/02/12 23:00:11, Jamie wrote:
> It seems that only the changes to remoting.js are mentioned in the CL
> description. Are the others intentional?
 
Yes. Updated the description.

https://codereview.chromium.org/160963003/diff/70001/remoting/webapp/host_lis...
File remoting/webapp/host_list.js (right):

https://codereview.chromium.org/160963003/diff/70001/remoting/webapp/host_lis...
remoting/webapp/host_list.js:83: this.localHostState_ =
remoting.HostController.State.UNKNOWN;
On 2014/02/12 23:00:12, Jamie wrote:
> I think UNKNOWN is still the right initial value for this, since fetching the
> state is an asynchronous operation. What's the downside to initializing it to
> UNKNOWN?

There is no downside. UNKNOWN is the right initial value here, that's why I'm
making this change

https://codereview.chromium.org/160963003/diff/70001/remoting/webapp/remoting.js
File remoting/webapp/remoting.js (right):

https://codereview.chromium.org/160963003/diff/70001/remoting/webapp/remoting...
remoting/webapp/remoting.js:180: * controls that allow to install and enable
Me2Me host.
On 2014/02/12 23:00:12, Jamie wrote:
> You've changed the semantics of this methods without changing its name.
Perhaps
> a better name would be something like isMe2MeInstallable?

Done.

[Jamie, 2014-02-13 01:38:26]

lgtm

https://codereview.chromium.org/160963003/diff/70001/remoting/webapp/host_lis...
File remoting/webapp/host_list.js (right):

https://codereview.chromium.org/160963003/diff/70001/remoting/webapp/host_lis...
remoting/webapp/host_list.js:83: this.localHostState_ =
remoting.HostController.State.UNKNOWN;
On 2014/02/13 00:44:11, Sergey Ulanov wrote:
> On 2014/02/12 23:00:12, Jamie wrote:
> > I think UNKNOWN is still the right initial value for this, since fetching
the
> > state is an asynchronous operation. What's the downside to initializing it
to
> > UNKNOWN?
> 
> There is no downside. UNKNOWN is the right initial value here, that's why I'm
> making this change

Sorry, I was reading it the wrong way round...

[Sergey Ulanov, 2014-02-13 01:55:40]

Committed patchset #2 manually as r250908 (presubmit successful).