Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: chrome/browser/ui/browser.cc

Issue 160963002: Reset UnloadController::is_attempting_to_close_browser_ when the download-in-progress prompt is can… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: IsFastTabUnloadEnabled Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 70062efbe7e8caf79e59ac89041c9b57ae5434fe..0ee08929328466ea829c11fe810be14ef5ecdb05 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -695,6 +695,14 @@ void Browser::InProgressDownloadResponse(bool cancel_downloads) {
// Show the download page so the user can figure-out what downloads are still
// in-progress.
chrome::ShowDownloads(this);
+
+ // Reset UnloadController::is_attempting_to_close_browser_ so that we don't
+ // prompt every time any tab is closed. http://crbug.com/305516
+ if (IsFastTabUnloadEnabled()) {
sky 2014/02/18 21:24:00 nit: no {}
benjhayden 2014/02/18 22:11:34 Done.
+ fast_unload_controller_->CancelWindowClose();
+ } else {
+ unload_controller_->CancelWindowClose();
+ }
}
Browser::DownloadClosePreventionType Browser::OkToCloseWithInProgressDownloads(
« no previous file with comments | « no previous file | chrome/browser/ui/fast_unload_controller.h » ('j') | chrome/browser/ui/fast_unload_controller.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698