Issue 160963002: Reset UnloadController::is_attempting_to_close_browser_ when the download-in-progress prompt is can…

Issue 160963002: Reset UnloadController::is_attempting_to_close_browser_ when the download-in-progress prompt is can… (Closed)

Created:
6 years, 10 months ago by benjhayden

Modified:
6 years, 10 months ago

Reviewers:
Sam McNally, sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reset UnloadController::is_attempting_to_close_browser_ when the download-in-progress prompt is canceled. This seems to have been broken by https://src.chromium.org/viewvc/chrome?view=rev&revision=217949 BUG=305516 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251939

Patch Set 2 : IsFastTabUnloadEnabled #

Total comments: 4

Patch Set 3 : sky comments #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -75 lines)			Patch
M	chrome/browser/ui/browser.cc	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/fast_unload_controller.h	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/fast_unload_controller.cc	View	1 2	2 chunks	+45 lines, -45 lines	0 comments	Download
M	chrome/browser/ui/unload_controller.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/unload_controller.cc	View	1 2	2 chunks	+22 lines, -22 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

benjhayden

PTAL and let me know if there's a better way to fix this.

6 years, 10 months ago (2014-02-12 21:13:03 UTC) #1

Sam McNally

lgtm with the same change to FastUnloadController. https://codereview.chromium.org/160963002/diff/1/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): https://codereview.chromium.org/160963002/diff/1/chrome/browser/ui/browser.cc#newcode696 chrome/browser/ui/browser.cc:696: unload_controller_->CancelWindowClose(); if ...

6 years, 10 months ago (2014-02-16 23:54:29 UTC) #2

benjhayden

Scott: PTAL for ownership? https://codereview.chromium.org/160963002/diff/1/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): https://codereview.chromium.org/160963002/diff/1/chrome/browser/ui/browser.cc#newcode696 chrome/browser/ui/browser.cc:696: unload_controller_->CancelWindowClose(); On 2014/02/16 23:54:29, Sam ...

6 years, 10 months ago (2014-02-18 18:08:25 UTC) #3

sky

LGTM https://codereview.chromium.org/160963002/diff/100001/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): https://codereview.chromium.org/160963002/diff/100001/chrome/browser/ui/browser.cc#newcode701 chrome/browser/ui/browser.cc:701: if (IsFastTabUnloadEnabled()) { nit: no {} https://codereview.chromium.org/160963002/diff/100001/chrome/browser/ui/fast_unload_controller.h File ...

6 years, 10 months ago (2014-02-18 21:24:00 UTC) #4

benjhayden

Thanks! https://codereview.chromium.org/160963002/diff/100001/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): https://codereview.chromium.org/160963002/diff/100001/chrome/browser/ui/browser.cc#newcode701 chrome/browser/ui/browser.cc:701: if (IsFastTabUnloadEnabled()) { On 2014/02/18 21:24:00, sky wrote: ...

6 years, 10 months ago (2014-02-18 22:11:33 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benjhayden@chromium.org/160963002/210001

6 years, 10 months ago (2014-02-18 23:48:34 UTC) #7

Message was sent while issue was closed.

Change committed as 251939

Expand Messages | Collapse Messages