[NaCl Addin] Fix dependencies in visual studio

[NaCl Addin] Fix dependencies in visual studio

This fixes a long standing issue where visual studio
would always attempt to re-build, and in particular
relink NaCl project.

The primary fix here is to make filenames in the .tlog
files always uppercase and always absolute.

The secondary fix is to make the linker step also honour
tlog dependencies so that MSBuild knows when it can skip
the link step.

BUG=155157
R=binji@chromium.org

Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1553

[binji, 2013-05-30 23:29:22]

msvc magic, lgtm!

https://codereview.chromium.org/16096014/diff/2001/visual_studio/NativeClient...
File visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs
(left):

https://codereview.chromium.org/16096014/diff/2001/visual_studio/NativeClient...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs:222: if
(sourceFile != null)
sourceFile can't be null now?

https://codereview.chromium.org/16096014/diff/2001/visual_studio/NativeClient...
File visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs
(right):

https://codereview.chromium.org/16096014/diff/2001/visual_studio/NativeClient...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs:179:
return GenerateResponseFileCommands();
strange that source isn't used here.

https://codereview.chromium.org/16096014/diff/2001/visual_studio/NativeClient...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs:215: if
(res && skippedExecution == false)
skippedExecution should always be false here, correct?

Or is it different from uppercase SkippedExecution?

https://codereview.chromium.org/16096014/diff/2001/visual_studio/NativeClient...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs:277:
return GenerateResponseFileCommands() ;
nit: remove space before ;

https://codereview.chromium.org/16096014/diff/2001/visual_studio/NativeClient...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs:277:
return GenerateResponseFileCommands() ;
sourceFile not needed?

[Sam Clegg, 2013-05-30 23:48:57]

https://codereview.chromium.org/16096014/diff/2001/visual_studio/NativeClient...
File visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs
(left):

https://codereview.chromium.org/16096014/diff/2001/visual_studio/NativeClient...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs:222: if
(sourceFile != null)
On 2013/05/30 23:29:22, binji wrote:
> sourceFile can't be null now?

I don't think it ever could have been...

https://codereview.chromium.org/16096014/diff/2001/visual_studio/NativeClient...
File visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs
(right):

https://codereview.chromium.org/16096014/diff/2001/visual_studio/NativeClient...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs:215: if
(res && skippedExecution == false)
On 2013/05/30 23:29:22, binji wrote:
> skippedExecution should always be false here, correct?
> 
> Or is it different from uppercase SkippedExecution?


Done.

https://codereview.chromium.org/16096014/diff/2001/visual_studio/NativeClient...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs:277:
return GenerateResponseFileCommands() ;
On 2013/05/30 23:29:22, binji wrote:
> nit: remove space before ;

Removed this function..

https://codereview.chromium.org/16096014/diff/2001/visual_studio/NativeClient...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs:277:
return GenerateResponseFileCommands() ;
On 2013/05/30 23:29:22, binji wrote:
> nit: remove space before ;

Removed this function.

[Sam Clegg, 2013-05-31 00:49:55]

Committed patchset #3 manually as r1553 (presubmit successful).