add a regression test for requestAutocomplete

chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/guid.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/prefs/pref_service.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
@@ skipping 290 matching lines @@
     for (size_t i = 0; i < arraysize(kFieldsFromPage); ++i) {
       FormFieldData field;
       field.autocomplete_attribute = kFieldsFromPage[i];
       form_data.fields.push_back(field);
     }
 
     profile()->CreateRequestContext();
     test_web_contents_.reset(
         content::WebContentsTester::CreateTestWebContents(profile(), NULL));
 
+    SetUpControllerWithFormData(form_data);
+  }
+
+  virtual void TearDown() OVERRIDE {
+    if (controller_)
+      controller_->ViewClosed();
+  }
+
+ protected:
+  void SetUpControllerWithFormData(const FormData& form_data) {
+    if (controller_)
+      controller_->ViewClosed();
+
     base::Callback<void(const FormStructure*, const std::string&)> callback =
         base::Bind(&AutofillDialogControllerTest::FinishedCallback,
                    base::Unretained(this));
     controller_ = (new testing::NiceMock<TestAutofillDialogController>(
         test_web_contents_.get(),
         form_data,
         GURL(),
         metric_logger_,
         DIALOG_TYPE_REQUEST_AUTOCOMPLETE,
         callback))->AsWeakPtr();
     controller_->Init(profile());
     controller_->Show();
     controller_->OnUserNameFetchSuccess(kFakeEmail);
   }
 
-  virtual void TearDown() OVERRIDE {
-    if (controller_)
-      controller_->ViewClosed();
-  }
-
- protected:
   void FillCreditCardInputs() {
     DetailOutputMap cc_outputs;
     const DetailInputs& cc_inputs =
         controller()->RequestedFieldsForSection(SECTION_CC);
     for (size_t i = 0; i < cc_inputs.size(); ++i) {
       cc_outputs[&cc_inputs[i]] = ASCIIToUTF16("11");
     }
     controller()->GetView()->SetUserInput(SECTION_CC, cc_outputs);
   }
 
@@ skipping 371 matching lines @@
   UseBillingForShipping();
 
   controller()->OnAccept();
   ASSERT_EQ(4U, form_structure()->field_count());
   EXPECT_EQ("CA", UTF16ToUTF8(form_structure()->field(2)->value));
   EXPECT_EQ("CA", UTF16ToUTF8(form_structure()->field(3)->value));
   EXPECT_EQ(ADDRESS_BILLING_STATE, form_structure()->field(2)->type());
   EXPECT_EQ(ADDRESS_HOME_STATE, form_structure()->field(3)->type());
 }
 
+// Tests that shipping and billing telephone fields are supported, and filled
+// in by their respective profiles. http://crbug.com/244515
+TEST_F(AutofillDialogControllerTest, DISABLED_BillingVsShippingPhoneNumber) {
+  FormFieldData shipping_tel;
+  shipping_tel.autocomplete_attribute = "shipping tel";
+  FormFieldData billing_tel;
+  billing_tel.autocomplete_attribute = "billing tel";
+
+  FormData form_data;
+  form_data.fields.push_back(shipping_tel);
+  form_data.fields.push_back(billing_tel);
+  SetUpControllerWithFormData(form_data);
+
+  AutofillProfile full_profile(test::GetVerifiedProfile());
+  AutofillProfile full_profile2(test::GetVerifiedProfile2());

[Dan Beam, 2013/05/28 19:17:49]

can you use {shipping,billing}_profile so it's more obvious what you're testing?

[Evan Stade, 2013/05/28 19:30:09]

Done.

+  CreditCard credit_card(test::GetVerifiedCreditCard());
+  controller()->GetTestingManager()->AddTestingProfile(&full_profile);
+  controller()->GetTestingManager()->AddTestingProfile(&full_profile2);
+  controller()->GetTestingManager()->AddTestingCreditCard(&credit_card);
+  ui::MenuModel* billing_model =
+      controller()->MenuModelForSection(SECTION_BILLING);
+  billing_model->ActivatedAt(1);
+
+  controller()->OnAccept();
+  ASSERT_EQ(2U, form_structure()->field_count());
+  EXPECT_EQ(PHONE_HOME_WHOLE_NUMBER, form_structure()->field(0)->type());
+  EXPECT_EQ(PHONE_HOME_WHOLE_NUMBER, form_structure()->field(1)->type());
+  EXPECT_EQ(full_profile.GetRawInfo(PHONE_HOME_WHOLE_NUMBER),
+            form_structure()->field(0)->value);
+  EXPECT_EQ(full_profile2.GetRawInfo(PHONE_HOME_WHOLE_NUMBER),
+            form_structure()->field(1)->value);
+  EXPECT_NE(form_structure()->field(1)->value,
+            form_structure()->field(0)->value);
+}
+
 TEST_F(AutofillDialogControllerTest, AcceptLegalDocuments) {
   EXPECT_CALL(*controller()->GetTestingWalletClient(),
               AcceptLegalDocuments(_, _, _)).Times(1);
   EXPECT_CALL(*controller()->GetTestingWalletClient(),
               GetFullWallet(_)).Times(1);
   EXPECT_CALL(*controller(), LoadRiskFingerprintData()).Times(1);
 
   scoped_ptr<wallet::WalletItems> wallet_items = wallet::GetTestWalletItems();
   wallet_items->AddLegalDocument(wallet::GetTestLegalDocument());
   wallet_items->AddInstrument(wallet::GetTestMaskedInstrument());
@@ skipping 946 matching lines @@
   controller()->OnDidGetWalletItems(
       wallet::WalletItems::CreateWalletItems(dict).Pass());
 
   EXPECT_FALSE(controller()->MenuModelForSection(SECTION_CC_BILLING));
   // "Same as billing" and "Add address...".
   EXPECT_EQ(
       2, controller()->MenuModelForSection(SECTION_SHIPPING)->GetItemCount());
 }
 
 }  // namespace autofill