Remove logging::LogAtLevel and rewrite its sole caller.

Remove logging::LogAtLevel and rewrite its sole caller.

This method causes log statements attributed to logging.h (inside the LogAtLevel
function) to be written, which is less than useful. It only has one caller, which
can easily be adjusted to use the ordinary LOG(...) macro with a small adjustment.

After this change, the log output is correctly attributed to object_proxy.cc.

Committed: https://crrev.com/a14517ffd5565b7572ead4014b9953edc4b17009
Cr-Commit-Position: refs/heads/master@{#370905}

[danakj, 2016-01-19 21:10:19]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2016-01-19 21:10:19]

Thanks!

https://codereview.chromium.org/1609563002/diff/1/base/logging.h
File base/logging.h (right):

https://codereview.chromium.org/1609563002/diff/1/base/logging.h#newcode378
base/logging.h:378: #define LOG_AT_LEVEL(severity)                              
                 \
I like this better than the method, yah. But I don't like having 2 ways to log
where one is compile time and one is runtime evaluated. It's like having a fork
and a spork, and it's not clear which to use really which will lead to misuse.

https://codereview.chromium.org/1609563002/diff/1/dbus/object_proxy.cc
File dbus/object_proxy.cc (right):

https://codereview.chromium.org/1609563002/diff/1/dbus/object_proxy.cc#newcod...
dbus/object_proxy.cc:574: LOG_AT_LEVEL(severity) << "Failed to call method: " <<
interface_name << "."
How about we delete the method in base and just make this code use LOG().

[jbroman, 2016-01-19 21:23:44]

Description was changed from

==========
Replace logging::LogAtLevel with a macro that shows the correct source location.

BUG=
==========

to

==========
Remove logging::LogAtLevel and rewrite its sole caller.

This method causes log statements attributed to logging.h (inside the LogAtLevel
function) to be written, which is less than useful. It only has one caller,
which
can easily be adjusted to use the ordinary LOG(...) macro with a small
adjustment.

After this change, the log output is correctly attributed to object_proxy.cc.
==========

[jbroman, 2016-01-19 21:28:11]

jbroman@chromium.org changed reviewers:
+ hashimoto@chromium.org

[jbroman, 2016-01-19 21:28:11]

danakj for base/OWNERS
hashimoto for dbus/OWNERS

https://codereview.chromium.org/1609563002/diff/1/dbus/object_proxy.cc
File dbus/object_proxy.cc (right):

https://codereview.chromium.org/1609563002/diff/1/dbus/object_proxy.cc#newcod...
dbus/object_proxy.cc:574: LOG_AT_LEVEL(severity) << "Failed to call method: " <<
interface_name << "."
On 2016/01/19 at 21:10:19, danakj wrote:
> How about we delete the method in base and just make this code use LOG().

Done.

[danakj, 2016-01-19 21:29:01]

LGTM

[jbroman, 2016-01-21 15:26:22]

ping hashimoto

[hashimoto, 2016-01-22 03:03:19]

lgtm

[jbroman, 2016-01-22 03:18:06]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-01-22 03:18:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1609563002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1609563002/20001

[commit-bot: I haz the power, 2016-01-22 04:49:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-22 04:50:43]

Description was changed from

==========
Remove logging::LogAtLevel and rewrite its sole caller.

This method causes log statements attributed to logging.h (inside the LogAtLevel
function) to be written, which is less than useful. It only has one caller,
which
can easily be adjusted to use the ordinary LOG(...) macro with a small
adjustment.

After this change, the log output is correctly attributed to object_proxy.cc.
==========

to

==========
Remove logging::LogAtLevel and rewrite its sole caller.

This method causes log statements attributed to logging.h (inside the LogAtLevel
function) to be written, which is less than useful. It only has one caller,
which
can easily be adjusted to use the ordinary LOG(...) macro with a small
adjustment.

After this change, the log output is correctly attributed to object_proxy.cc.

Committed: https://crrev.com/a14517ffd5565b7572ead4014b9953edc4b17009
Cr-Commit-Position: refs/heads/master@{#370905}
==========

[commit-bot: I haz the power, 2016-01-22 04:50:43]

Patchset 2 (id:??) landed as
https://crrev.com/a14517ffd5565b7572ead4014b9953edc4b17009
Cr-Commit-Position: refs/heads/master@{#370905}