Magnification controller: fix incorrect point of interest.

Magnification controller: fix incorrect point of interest.

MagnificationControllerImpl::OnMouseEvent() should not update
point of interest for mouse events of type ET_MOUSE_CAPTURE_CHANGED
because they do not contain valid coordinates.

BUG=312496
TEST=verified cursor no longer jumps
R=oshima@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250832

[hshi1, 2014-02-12 19:47:59]

@oshima PTAL thanks! We should not update |point_of_interest_| for
ET_MOUSE_CAPTURE_CHANGED events because they have no coordinates (location is
0,0).

[oshima, 2014-02-12 20:28:19]

+sadrul

It's a bit fragile to check if the location is valid this way. sadrul, is it
possible to add a flag/method that tells if the event contains the valid
location (like has_location(), is_location_valid()) ?

[hshi1, 2014-02-12 21:14:47]

On 2014/02/12 20:28:19, oshima wrote:
> +sadrul
> 
> It's a bit fragile to check if the location is valid this way. sadrul, is it
> possible to add a flag/method that tells if the event contains the valid
> location (like has_location(), is_location_valid()) ?

Uploaded Patch Set #2: does this look ok to you?

[hshi1, 2014-02-12 22:04:17]

On 2014/02/12 21:14:47, hshi1 wrote:
> On 2014/02/12 20:28:19, oshima wrote:
> > +sadrul
> > 
> > It's a bit fragile to check if the location is valid this way. sadrul, is it
> > possible to add a flag/method that tells if the event contains the valid
> > location (like has_location(), is_location_valid()) ?
> 
> Uploaded Patch Set #2: does this look ok to you?

(talked to oshima offline) on second thought, let's just fix the
MagnificationController in this CL.

However we probably should review and refactor
LocatedEvent::has_valid_location() in a separate CL.

[oshima, 2014-02-12 22:07:57]

lgtm

[hshi1, 2014-02-12 22:12:23]

The CQ bit was checked by hshi@chromium.org

[commit-bot: I haz the power, 2014-02-12 22:13:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hshi@chromium.org/160953002/180001

[hshi1, 2014-02-12 23:19:35]

Committed patchset #3 manually as r250832 (presubmit successful).