Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 16094012: Fix unitialized pointer in RulesRegistryService. (Closed)

Created:
7 years, 6 months ago by Dan Beam
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, battre
Visibility:
Public.

Description

Fix unitialized pointer in RulesRegistryService. TBR=thestig@chromium.org BUG=none TEST=less memcheck issues Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202994

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/extensions/api/declarative/rules_registry_service.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Dan Beam
7 years, 6 months ago (2013-05-29 04:26:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/16094012/1
7 years, 6 months ago (2013-05-29 04:27:38 UTC) #2
Dan Beam
note to self, can probably [re-]revert r202764 after this lands
7 years, 6 months ago (2013-05-29 04:27:55 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-05-29 05:04:31 UTC) #4
Lei Zhang
Compile fail.
7 years, 6 months ago (2013-05-29 06:23:15 UTC) #5
Dan Beam
d'oh
7 years, 6 months ago (2013-05-29 08:59:52 UTC) #6
Dan Beam
fixed
7 years, 6 months ago (2013-05-29 19:14:44 UTC) #7
Lei Zhang
lgtm
7 years, 6 months ago (2013-05-29 19:36:36 UTC) #8
Lei Zhang
+battre FYI
7 years, 6 months ago (2013-05-29 19:37:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/16094012/20001
7 years, 6 months ago (2013-05-29 20:35:08 UTC) #10
commit-bot: I haz the power
Change committed as 202994
7 years, 6 months ago (2013-05-29 22:53:04 UTC) #11
Dan Beam
7 years, 6 months ago (2013-05-29 23:16:31 UTC) #12
Message was sent while issue was closed.
On 2013/05/29 04:27:55, Dan Beam wrote:
> note to self, can probably [re-]revert r202764 after this lands

other note to self - it was actually r202751

Powered by Google App Engine
This is Rietveld 408576698