drive: Respect is_recursive parameter in RemoveOperation.

chrome/browser/chromeos/drive/file_system/remove_operation.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/drive/file_system/remove_operation.h"
 
 #include "chrome/browser/chromeos/drive/drive.pb.h"
 #include "chrome/browser/chromeos/drive/file_cache.h"
 #include "chrome/browser/chromeos/drive/file_system/operation_observer.h"
 #include "chrome/browser/chromeos/drive/file_system_util.h"
@@ skipping 14 matching lines @@
     metadata_(metadata),
     cache_(cache),
     weak_ptr_factory_(this) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 }
 
 RemoveOperation::~RemoveOperation() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 }
 
-void RemoveOperation::Remove(const base::FilePath& file_path,
+void RemoveOperation::Remove(const base::FilePath& path,
                              bool is_recursive,
                              const FileOperationCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   DCHECK(!callback.is_null());
 
-  // Get the edit URL of an entry at |file_path|.
+  // Get the edit URL of an entry at |path|.
   metadata_->GetResourceEntryByPathOnUIThread(
-      file_path,
+      path,
       base::Bind(
           &RemoveOperation::RemoveAfterGetResourceEntry,
           weak_ptr_factory_.GetWeakPtr(),
+          path,
+          is_recursive,
           callback));
 }
 
 void RemoveOperation::RemoveAfterGetResourceEntry(
+    const base::FilePath& path,
+    bool is_recursive,
     const FileOperationCallback& callback,
     FileError error,
     scoped_ptr<ResourceEntry> entry) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   DCHECK(!callback.is_null());
 
   if (error != FILE_ERROR_OK) {
     callback.Run(error);
     return;
   }
-  DCHECK(entry);
+
+  if (entry->file_info().is_directory() && !is_recursive) {
+    // Check emptiness of the directory.
+    metadata_->ReadDirectoryByPathOnUIThread(
+        path,
+        base::Bind(&RemoveOperation::RemoveAfterReadDirectory,
+                   weak_ptr_factory_.GetWeakPtr(),
+                   entry->resource_id(),
+                   callback));
+    return;
+  }
 
   scheduler_->DeleteResource(
       entry->resource_id(),
       base::Bind(&RemoveOperation::RemoveResourceLocally,
                  weak_ptr_factory_.GetWeakPtr(),
                  callback,
                  entry->resource_id()));
 }
 
+void RemoveOperation::RemoveAfterReadDirectory(
+    const std::string& resource_id,
+    const FileOperationCallback& callback,
+    FileError error,
+    scoped_ptr<ResourceEntryVector> entries) {

[hashimoto, 2013/05/28 02:34:45]

nit: How about having DCHECKs for CurrentlyOn(BrowserThread::UI) and
!callback.is_null()?

[kinaba, 2013/05/28 03:31:28]

Done.

+  if (error != FILE_ERROR_OK) {
+    callback.Run(error);
+    return;
+  }
+
+  if (!entries->empty()) {
+    callback.Run(FILE_ERROR_NOT_EMPTY);
+    return;
+  }
+
+  scheduler_->DeleteResource(
+      resource_id,
+      base::Bind(&RemoveOperation::RemoveResourceLocally,
+                 weak_ptr_factory_.GetWeakPtr(),
+                 callback,
+                 resource_id));
+}
+
 void RemoveOperation::RemoveResourceLocally(
     const FileOperationCallback& callback,
     const std::string& resource_id,
     google_apis::GDataErrorCode status) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   DCHECK(!callback.is_null());
 
   FileError error = util::GDataToFileError(status);
   if (error != FILE_ERROR_OK) {
     callback.Run(error);
@@ skipping 18 matching lines @@
   DCHECK(!callback.is_null());
 
   if (error == FILE_ERROR_OK)
     observer_->OnDirectoryChangedByOperation(directory_path);
 
   callback.Run(error);
 }
 
 }  // namespace file_system
 }  // namespace drive