Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

Issue 1609343004: Add display list fallback reason histograms for 2D canvas (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adding missing histogram Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
index 07a62ea5587f2ff592a812e4e0c7b9b6349a9656..62cc704cc60108ba6e859f57d1a3bff6ed96339b 100644
--- a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
@@ -432,7 +432,7 @@ void HTMLCanvasElement::notifyListenersCanvasChanged()
if (listenerNeedsNewFrameCapture) {
SourceImageStatus status;
- RefPtr<Image> sourceImage = getSourceImageForCanvas(&status, PreferNoAcceleration);
+ RefPtr<Image> sourceImage = getSourceImageForCanvas(&status, PreferNoAcceleration, SnapshotReasonCanvasListenerCapture);
if (status != NormalSourceImageStatus)
return;
RefPtr<SkImage> image = sourceImage->imageForCurrentFrame();
@@ -513,7 +513,7 @@ void HTMLCanvasElement::prepareSurfaceForPaintingIfNeeded() const
m_imageBuffer->prepareSurfaceForPaintingIfNeeded();
}
-ImageData* HTMLCanvasElement::toImageData(SourceDrawingBuffer sourceBuffer) const
+ImageData* HTMLCanvasElement::toImageData(SourceDrawingBuffer sourceBuffer, SnapshotReason reason) const
{
ImageData* imageData;
if (is3D()) {
@@ -524,7 +524,7 @@ ImageData* HTMLCanvasElement::toImageData(SourceDrawingBuffer sourceBuffer) cons
m_context->paintRenderingResultsToCanvas(sourceBuffer);
imageData = ImageData::create(m_size);
- RefPtr<SkImage> snapshot = buffer()->newSkImageSnapshot(PreferNoAcceleration);
+ RefPtr<SkImage> snapshot = buffer()->newSkImageSnapshot(PreferNoAcceleration, reason);
if (snapshot) {
SkImageInfo imageInfo = SkImageInfo::Make(width(), height(), kRGBA_8888_SkColorType, kUnpremul_SkAlphaType);
snapshot->readPixels(imageInfo, imageData->data()->data(), imageInfo.minRowBytes(), 0, 0);
@@ -538,7 +538,7 @@ ImageData* HTMLCanvasElement::toImageData(SourceDrawingBuffer sourceBuffer) cons
return imageData;
ASSERT(m_context->is2d());
- RefPtr<SkImage> snapshot = buffer()->newSkImageSnapshot(PreferNoAcceleration);
+ RefPtr<SkImage> snapshot = buffer()->newSkImageSnapshot(PreferNoAcceleration, reason);
if (snapshot) {
SkImageInfo imageInfo = SkImageInfo::Make(width(), height(), kRGBA_8888_SkColorType, kUnpremul_SkAlphaType);
snapshot->readPixels(imageInfo, imageData->data()->data(), imageInfo.minRowBytes(), 0, 0);
@@ -554,7 +554,7 @@ String HTMLCanvasElement::toDataURLInternal(const String& mimeType, const double
String encodingMimeType = toEncodingMimeType(mimeType);
- ImageData* imageData = toImageData(sourceBuffer);
+ ImageData* imageData = toImageData(sourceBuffer, SnapshotReasonToDataURL);
ScopedDisposal<ImageData> disposer(imageData);
return ImageDataBuffer(imageData->size(), imageData->data()->data()).toDataURL(encodingMimeType, quality);
@@ -599,7 +599,7 @@ void HTMLCanvasElement::toBlob(FileCallback* callback, const String& mimeType, c
String encodingMimeType = toEncodingMimeType(mimeType);
- ImageData* imageData = toImageData(BackBuffer);
+ ImageData* imageData = toImageData(BackBuffer, SnapshotReasonToBlob);
// imageData unref its data, which we still keep alive for the async toBlob thread
ScopedDisposal<ImageData> disposer(imageData);
// Add a ref to keep image data alive until completion of encoding
@@ -846,10 +846,10 @@ SkCanvas* HTMLCanvasElement::drawingCanvas() const
return buffer() ? m_imageBuffer->canvas() : nullptr;
}
-void HTMLCanvasElement::disableDeferral() const
+void HTMLCanvasElement::disableDeferral(DisableDeferralReason reason) const
{
if (buffer())
- m_imageBuffer->disableDeferral();
+ m_imageBuffer->disableDeferral(reason);
}
SkCanvas* HTMLCanvasElement::existingDrawingCanvas() const
@@ -954,7 +954,7 @@ void HTMLCanvasElement::didMoveToNewDocument(Document& oldDocument)
HTMLElement::didMoveToNewDocument(oldDocument);
}
-PassRefPtr<Image> HTMLCanvasElement::getSourceImageForCanvas(SourceImageStatus* status, AccelerationHint hint) const
+PassRefPtr<Image> HTMLCanvasElement::getSourceImageForCanvas(SourceImageStatus* status, AccelerationHint hint, SnapshotReason reason) const
{
if (!width() || !height()) {
*status = ZeroSizeCanvasSourceImageStatus;
@@ -975,7 +975,7 @@ PassRefPtr<Image> HTMLCanvasElement::getSourceImageForCanvas(SourceImageStatus*
m_context->paintRenderingResultsToCanvas(BackBuffer);
}
- RefPtr<SkImage> image = buffer()->newSkImageSnapshot(hint);
+ RefPtr<SkImage> image = buffer()->newSkImageSnapshot(hint, reason);
if (image) {
*status = NormalSourceImageStatus;
return StaticBitmapImage::create(image.release());

Powered by Google App Engine
This is Rietveld 408576698