Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: toolchain_build/toolchain_build_pnacl.py

Issue 1609323002: Revert of [PNaCl Toolchain] Use static libc++ from Chrome toolchain on Mac (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: toolchain_build/toolchain_build_pnacl.py
diff --git a/toolchain_build/toolchain_build_pnacl.py b/toolchain_build/toolchain_build_pnacl.py
index f9248f2df4c4480f185c98c9425adf1b00336fe0..218ddd9cddcb30dadfc2c3d33ea395aac5d65d17 100755
--- a/toolchain_build/toolchain_build_pnacl.py
+++ b/toolchain_build/toolchain_build_pnacl.py
@@ -93,8 +93,6 @@
CHROME_CLANG = os.path.join(os.path.dirname(NACL_DIR), 'third_party',
'llvm-build', 'Release+Asserts', 'bin', 'clang')
CHROME_CLANGXX = CHROME_CLANG + '++'
-CHROME_LIBCXX_STATIC = os.path.join(os.path.dirname(NACL_DIR), 'third_party',
- 'libc++-static')
# Required SDK version and target version for Mac builds.
# See MAC_SDK_FLAGS, below.
@@ -287,8 +285,6 @@
result['LDFLAGS'] += ['-L%(' + FlavoredName('abs_libcxx',
host, opts) + ')s/lib']
deps.append(FlavoredName('libcxx', host, opts))
- elif TripleIsMac(host):
- result['LDFLAGS'] += ['-L' + CHROME_LIBCXX_STATIC]
result['CFLAGS'] += extra_cc_flags
result['CXXFLAGS'] += extra_cc_flags
@@ -334,7 +330,7 @@
if not options.gcc:
cc, cxx, ar, ranlib = CompilersForHost(host)
- hashables += [cc, cxx, ar, ranlib, CHROME_LIBCXX_STATIC]
+ hashables += [cc, cxx, ar, ranlib]
# Introduce afl-fuzz compiler wrappers if needed.
if use_afl_fuzz:
@@ -407,7 +403,7 @@
cc, cxx = AflFuzzCompilers(options.afl_fuzz_dir)
else:
cc, cxx, _, _ = CompilersForHost(host)
- hashables = [cc, cxx, CHROME_LIBCXX_STATIC]
+ hashables = [cc, cxx]
cmake_flags.extend(['-DCMAKE_C_COMPILER='+cc, '-DCMAKE_CXX_COMPILER='+cxx])
if ProgramPath('ccache'):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698