Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1609323002: Revert of [PNaCl Toolchain] Use static libc++ from Chrome toolchain on Mac (Closed)

Created:
4 years, 11 months ago by Derek Schuff
Modified:
4 years, 11 months ago
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Revert of [PNaCl Toolchain] Use static libc++ from Chrome toolchain on Mac (patchset #2 id:20001 of https://codereview.chromium.org/1586243003/ ) Reason for revert: This change breaks the LLVM regression tests Original issue's description: > [PNaCl Toolchain] Use static libc++ from Chrome toolchain on Mac > > https://codereview.chromium.org/1572753002/ stopped building our custom libc++ > but failed to add the linker path to the static libc++ library, resulting in > a dependence on the system libc++ dylib. This fails for OSX 10.6 systems, which > don't have the dylib. > > BUG=None > R=mcgrathr@chromium.org > > Committed: https://chromium.googlesource.com/native_client/src/native_client/+/2d5bba1b48c0d3091df391c81ed7cd3236c0a127 TBR=mcgrathr@chromium.org,mseaborn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://chromium.googlesource.com/native_client/src/native_client/+/bdd3ffafb42879e2beddf73e45f3c3ee115f462f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M toolchain_build/toolchain_build_pnacl.py View 4 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Derek Schuff
Created Revert of [PNaCl Toolchain] Use static libc++ from Chrome toolchain on Mac
4 years, 11 months ago (2016-01-20 17:43:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1609323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1609323002/1
4 years, 11 months ago (2016-01-20 17:43:08 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 17:43:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/bdd3ffafb...

Powered by Google App Engine
This is Rietveld 408576698