Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 16093029: [Android] Binary files for Fixed default bookmark shortcut icon drawing. (Closed)

Created:
7 years, 6 months ago by Kibeom Kim (inactive)
Modified:
6 years, 4 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Binary files for Fixed default bookmark shortcut icon drawing. This contains the binary drawables related to this CL: https://codereview.chromium.org/15992008/ BUG=241380 R=tedchoc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203994

Patch Set 1 #

Messages

Total messages: 9 (0 generated)
Kibeom Kim (inactive)
7 years, 6 months ago (2013-06-04 17:15:59 UTC) #1
Ted C
lgtm
7 years, 6 months ago (2013-06-04 17:17:33 UTC) #2
newt (away)
Committed patchset #1 manually as r203994 (presubmit successful).
7 years, 6 months ago (2013-06-04 17:37:03 UTC) #3
aurimas (slooooooooow)
On 2013/06/04 17:37:03, newt wrote: > Committed patchset #1 manually as r203994 (presubmit successful). Random ...
6 years, 4 months ago (2014-08-14 04:29:52 UTC) #4
Kibeom Kim (inactive)
On 2014/08/14 04:29:52, aurimas wrote: > On 2013/06/04 17:37:03, newt wrote: > > Committed patchset ...
6 years, 4 months ago (2014-08-14 06:56:41 UTC) #5
Kibeom Kim (inactive)
On 2014/08/14 06:56:41, Kibeom Kim wrote: > On 2014/08/14 04:29:52, aurimas wrote: > > On ...
6 years, 4 months ago (2014-08-14 07:54:01 UTC) #6
Ted C
On 2014/08/14 07:54:01, Kibeom Kim wrote: > On 2014/08/14 06:56:41, Kibeom Kim wrote: > > ...
6 years, 4 months ago (2014-08-14 19:04:01 UTC) #7
Ted C
On 2014/08/14 07:54:01, Kibeom Kim wrote: > On 2014/08/14 06:56:41, Kibeom Kim wrote: > > ...
6 years, 4 months ago (2014-08-14 19:04:01 UTC) #8
Kibeom Kim (inactive)
6 years, 4 months ago (2014-08-14 20:06:12 UTC) #9
Message was sent while issue was closed.
On 2014/08/14 19:04:01, Ted C wrote:
> On 2014/08/14 07:54:01, Kibeom Kim wrote:
> > On 2014/08/14 06:56:41, Kibeom Kim wrote:
> > > On 2014/08/14 04:29:52, aurimas wrote:
> > > > On 2013/06/04 17:37:03, newt wrote:
> > > > > Committed patchset #1 manually as r203994 (presubmit successful).
> > > > 
> > > > Random question: why did we put these images under mipmap?
> > > 
> > > The question seriously challenges my memorization. :) I barely remember
that
> > it
> > > was something to do with how Android deals launcher icons.
> > > 
> > > Random answer:
> > >
https://groups.google.com/d/msg/android-developers/ZUyF0JEwibs/5w3dC4aS0zsJ
> > 
> > OK, I looked up where we're using this resource, BookmarkUtils.java, and it
> > seems mipmap-*/ doesn't make any difference in this case. I could be wrong
of
> > course.
> 
> If I recall, mipmap is better for home screen assets as they can more
correctly
> use ones for the device/density without scaling artifacts of other resource
> types (same reason we put our chrome icons in mipmap folders).

This is a simplified snippet how we're using the mipmap asset in
BookmarkUtils.java:

int iconDensity = (ActivityManager)
context.getSystemService(Context.ACTIVITY_SERVICE).getLauncherLargeIconSize();
Bitmap bookmarkWidgetBg = getBitmapFromResourceId(context,
R.mipmap.bookmark_widget_bg, iconDensity);
canvas.drawBitmap(bookmarkWidgetBg, null, iconBounds, paint);

So we just directly request the exact density asset first and convert it to
Bitmap. It doesn't seem any mipmap scaling is involved here.

Powered by Google App Engine
This is Rietveld 408576698