Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: tools/rebaseline.py

Issue 16093025: rebaseline.py: if --tests is not specified, get test list from actual-results.json (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: loop_over_subdirs_first Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/rebaseline.py
===================================================================
--- tools/rebaseline.py (revision 9426)
+++ tools/rebaseline.py (working copy)
@@ -164,13 +164,13 @@
# Rebaseline all platforms/tests/types we specified in the constructor.
def RebaselineAll(self):
- for test in self._tests:
- for subdir in self._subdirs:
- if not subdir in SUBDIR_MAPPING.keys():
- raise Exception(('unrecognized platform subdir "%s"; ' +
- 'should be one of %s') % (
- subdir, SUBDIR_MAPPING.keys()))
- builder_name = SUBDIR_MAPPING[subdir]
+ for subdir in self._subdirs:
+ if not subdir in SUBDIR_MAPPING.keys():
+ raise Exception(('unrecognized platform subdir "%s"; ' +
+ 'should be one of %s') % (
+ subdir, SUBDIR_MAPPING.keys()))
+ builder_name = SUBDIR_MAPPING[subdir]
+ for test in self._tests:
epoger 2013/06/04 16:01:22 Patchset 2 loops over subdirs first, and then in t
self._RebaselineOneTest(expectations_subdir=subdir,
builder_name=builder_name,
test=test)
@@ -187,13 +187,19 @@
help='instead of actually downloading files or adding ' +
'files to checkout, display a list of operations that ' +
'we would normally perform')
+parser.add_argument('--json_base_url',
+ help='base URL from which to read actual-results.json ' +
+ 'files; defaults to %(default)s',
+ default='http://skia-autogen.googlecode.com/svn/gm-actual')
parser.add_argument('--subdirs', metavar='SUBDIR', nargs='+',
help='which platform subdirectories to rebaseline; ' +
'if unspecified, rebaseline all subdirs, same as ' +
'"--subdirs %s"' % ' '.join(sorted(SUBDIR_MAPPING.keys())))
parser.add_argument('--tests', metavar='TEST', nargs='+', required=True,
help='which tests to rebaseline, e.g. ' +
- '"--tests aaclip bigmatrix"')
+ '"--tests aaclip bigmatrix"; if unspecified, then all ' +
+ 'failing tests (according to the actual-results.json ' +
+ 'file) will be rebaselined.')
args = parser.parse_args()
rebaseliner = Rebaseliner(tests=args.tests, configs=args.configs,
subdirs=args.subdirs, dry_run=args.dry_run)
« no previous file with comments | « no previous file | tools/tests/rebaseline/all/output-expected/stdout » ('j') | tools/tests/rebaseline/subset/output-expected/stdout » ('J')

Powered by Google App Engine
This is Rietveld 408576698