Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1609293003: Removing WKWebViewSearchParam (Closed)

Created:
4 years, 11 months ago by shreyasv1
Modified:
4 years, 11 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing WKWebViewSearchParam This is no longer needed. BUG=579249 Committed: https://crrev.com/9ecc86459f84b934176e831e7e4f888c91779c4f Cr-Commit-Position: refs/heads/master@{#370717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -32 lines) Patch
M components/search_engines/search_terms_data.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/search_engines/search_terms_data.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/experimental_flags.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 1 chunk +0 lines, -8 lines 0 comments Download
M ios/chrome/browser/search_engines/ui_thread_search_terms_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/search_engines/ui_thread_search_terms_data.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
shreyasv1
4 years, 11 months ago (2016-01-20 20:53:35 UTC) #2
rohitrao (ping after 24h)
LGTM, please have Colin take a look as well.
4 years, 11 months ago (2016-01-20 20:54:53 UTC) #4
blundell
LGTM
4 years, 11 months ago (2016-01-21 09:09:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1609293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1609293003/1
4 years, 11 months ago (2016-01-21 16:09:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 17:04:41 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 17:06:01 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9ecc86459f84b934176e831e7e4f888c91779c4f
Cr-Commit-Position: refs/heads/master@{#370717}

Powered by Google App Engine
This is Rietveld 408576698