src/builtins.h - Issue 1609233002: Do not eagerly instantiate accessors' JSFunction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.h

Issue 1609233002: Do not eagerly instantiate accessors' JSFunction. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Update. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins.h

diff --git a/src/builtins.h b/src/builtins.h

index b9629d28d16713d099713b6a3cc8b192c57b2e9c..9b5bf2b8bdaf710641ec6f0082668b9b83881bbe 100644

--- a/src/builtins.h

+++ b/src/builtins.h

@@ -363,7 +363,7 @@ class Builtins {

bool is_initialized() const { return initialized_; }

MUST_USE_RESULT static MaybeHandle<Object> InvokeApiFunction(

- Handle<JSFunction> function, Handle<Object> receiver, int argc,

+ Handle<HeapObject> function, Handle<Object> receiver, int argc,

Handle<Object> args[]);

private: