Do not eagerly instantiate accessors' JSFunction.

src/api-natives.cc

Index: src/api-natives.cc
diff --git a/src/api-natives.cc b/src/api-natives.cc
index 7fb88a6e46859a12810af78dbfc4c23775e57d04..12851002e8d7a06aa99b71ffe46fa7047c180857 100644
--- a/src/api-natives.cc
+++ b/src/api-natives.cc
@@ -43,20 +43,6 @@ MaybeHandle<Object> DefineAccessorProperty(Isolate* isolate,
                                            Handle<Object> getter,
                                            Handle<Object> setter,
                                            PropertyAttributes attributes) {

[Toon Verwaest, 2016/01/28 12:05:19]

To default to not instantiating the FunctionTemplates, we definitely need to
DCHECK here that the templates are marked as caching:

DCHECK(!accessor->do_not_cache());

Note that this changes V8's API.

[epertoso, 2016/02/01 16:18:03]

Done. But I don't get how this changes the API. We only set do_not_cache when we
create a new v8::Function (and that's fine, because we immediately instantiate
the template).

-  if (!getter->IsUndefined()) {
-    ASSIGN_RETURN_ON_EXCEPTION(
-        isolate, getter,
-        InstantiateFunction(isolate,
-                            Handle<FunctionTemplateInfo>::cast(getter)),
-        Object);
-  }
-  if (!setter->IsUndefined()) {
-    ASSIGN_RETURN_ON_EXCEPTION(
-        isolate, setter,
-        InstantiateFunction(isolate,
-                            Handle<FunctionTemplateInfo>::cast(setter)),
-        Object);
-  }
   RETURN_ON_EXCEPTION(isolate, JSObject::DefineAccessor(object, name, getter,
                                                         setter, attributes),
                       Object);