Do not eagerly instantiate accessors' JSFunction.

src/builtins.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins.h"
 
 #include "src/api.h"
 #include "src/api-natives.h"
 #include "src/arguments.h"
 #include "src/base/once.h"
@@ skipping 64 matching lines @@
   return Arguments::length();
 }
 
 template <>
 int BuiltinArguments<BuiltinExtraArguments::kTarget>::length() const {
   return Arguments::length() - 1;
 }
 
 template <>
 Handle<JSFunction> BuiltinArguments<BuiltinExtraArguments::kTarget>::target() {
-  return Arguments::at<JSFunction>(Arguments::length() - 1);
+  return Handle<JSFunction>(reinterpret_cast<JSFunction*>(
+      Arguments::operator[](Arguments::length() - 1)));
 }
 
 template <>
 int BuiltinArguments<BuiltinExtraArguments::kNewTarget>::length() const {
   return Arguments::length() - 1;
 }
 
 template <>
 Handle<HeapObject>
 BuiltinArguments<BuiltinExtraArguments::kNewTarget>::new_target() {
@@ skipping 3301 matching lines @@
 // -----------------------------------------------------------------------------
 //
 
 
 namespace {
 
 template <bool is_construct>
 MUST_USE_RESULT MaybeHandle<Object> HandleApiCallHelper(
     Isolate* isolate, BuiltinArguments<BuiltinExtraArguments::kTarget> args) {
   HandleScope scope(isolate);
-  Handle<JSFunction> function = args.target();
+  Handle<HeapObject> function = args.target();
   DCHECK(args.receiver()->IsJSReceiver());
   // TODO(ishell): turn this back to a DCHECK.
-  CHECK(function->shared()->IsApiFunction());
+  CHECK(function->IsFunctionTemplateInfo() ||
+        Handle<JSFunction>::cast(function)->shared()->IsApiFunction());
 
-  Handle<FunctionTemplateInfo> fun_data(
-      function->shared()->get_api_func_data(), isolate);
+  Handle<FunctionTemplateInfo> fun_data =
+      function->IsFunctionTemplateInfo()
+          ? Handle<FunctionTemplateInfo>::cast(function)
+          : Handle<FunctionTemplateInfo>(Handle<JSFunction>::cast(function)

[Toon Verwaest, 2016/01/22 12:11:36]

Shorter: handle(JSFunction::cast(*function)->shared()->get_api_func_data());

[epertoso, 2016/01/22 14:36:35]

Done.

+                                             ->shared()
+                                             ->get_api_func_data(),
+                                         isolate);
   if (is_construct) {
     ASSIGN_RETURN_ON_EXCEPTION(
         isolate, fun_data,
         ApiNatives::ConfigureInstance(isolate, fun_data,
                                       Handle<JSObject>::cast(args.receiver())),
         Object);
   }
 
   if (!is_construct && !fun_data->accept_any_receiver()) {
     Handle<JSReceiver> receiver = args.at<JSReceiver>(0);
@@ skipping 117 matching lines @@
     v->VisitPointers(lowest_address(), highest_address() + 1);
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(RelocatableArguments);
 };
 
 }  // namespace
 
 
-MaybeHandle<Object> Builtins::InvokeApiFunction(Handle<JSFunction> function,
+MaybeHandle<Object> Builtins::InvokeApiFunction(Handle<HeapObject> function,
                                                 Handle<Object> receiver,
                                                 int argc,
                                                 Handle<Object> args[]) {
   // Construct BuiltinArguments object: function, arguments reversed, receiver.
   const int kBufferSize = 32;
   Object* small_argv[kBufferSize];
   Object** argv;
   if (argc + 2 <= kBufferSize) {
     argv = small_argv;
   } else {
@@ skipping 436 matching lines @@
 BUILTIN_LIST_C(DEFINE_BUILTIN_ACCESSOR_C)
 BUILTIN_LIST_A(DEFINE_BUILTIN_ACCESSOR_A)
 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H)
 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A)
 #undef DEFINE_BUILTIN_ACCESSOR_C
 #undef DEFINE_BUILTIN_ACCESSOR_A
 
 
 }  // namespace internal
 }  // namespace v8