Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16092013: Use base::MessageLoop in more files. (Closed)

Created:
7 years, 6 months ago by xhwang
Modified:
7 years, 6 months ago
Reviewers:
Lei Zhang, brettw
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, tzik+watch_chromium.org, amit, ahutter, browser-components-watch_chromium.org, Raman Kakilate, kinuko+watch, Ilya Sherman, sergeyu+watch_chromium.org, dcaiafa+watch_chromium.org, cbentzel+watch_chromium.org, vsevik, ben+watch_chromium.org, benquan, jam, dbeam+watch-autofill_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, android-webview-reviews_chromium.org, tim (not reviewing), jamiewalch+watch_chromium.org, wez+watch_chromium.org, Raghu Simha, sanjeevr, penghuang+watch_chromium.org, feature-media-reviews_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, Albert Bodenhamer, haitaol1, alexeypa+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, hclam+watch_chromium.org, akalin, tfarina, yurys, garykac+watch_chromium.org, Aaron Boodman, lambroslambrou+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, cc-bugs_chromium.org, James Su, pfeldman
Visibility:
Public.

Description

Use base::MessageLoop in more files. These are either missed in the first pass, or added after the first pass. TBR=thestig@chromium.org BUG=236029 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203259

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : rebase #

Patch Set 7 : rebase again, sigh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -136 lines) Patch
M android_webview/browser/aw_form_database_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/in_process_renderer/in_process_renderer_client.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M android_webview/browser/in_process_renderer/in_process_view_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/shell_window_geometry_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/deferred_sequenced_task_runner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/hi_res_timer_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/mac/libdispatch_task_runner_unittest.cc View 1 2 5 chunks +6 lines, -5 lines 0 comments Download
M base/message_loop_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M base/timer_unittest.cc View 21 chunks +48 lines, -47 lines 0 comments Download
M cc/test/fake_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_adb_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printer_query.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_apitest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/browser_thread_model_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/generic_change_processor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/history_model_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/password_model_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/ui_model_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/history_data_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/history_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/theme_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/pyautolib/pyautolib.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/browser/personal_data_manager_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/webdata/common/web_data_request_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/smooth_scroll_gesture_controller_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M content/public/test/mock_render_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_profile_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/one_shot_event_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/media_source_player.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_resolver_v8_tracing.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/setup/start_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/token_validator_factory_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/sync_scheduler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/engine/model_safe_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/accounts_client/test_accounts_client.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/accounts_client/test_accounts_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/dispatcher_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/env.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/env.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/win/singleton_hwnd.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/surface/accelerated_surface_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/blob/blob_storage_context_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M webkit/browser/fileapi/transient_file_util_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/simple_file_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/simple_socket_stream_bridge.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webblobregistry_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/16092013/29003
7 years, 6 months ago (2013-05-30 21:48:11 UTC) #1
Lei Zhang
chrome/ lgtm
7 years, 6 months ago (2013-05-30 22:02:28 UTC) #2
Lei Zhang
The rest of the changes lgtm too.
7 years, 6 months ago (2013-05-30 22:11:45 UTC) #3
xhwang
7 years, 6 months ago (2013-05-30 23:11:11 UTC) #4
Message was sent while issue was closed. 
Committed patchset #7 manually as r203259 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698