HTTP loading tests and package root support

runtime/bin/builtin.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library builtin;
 import 'dart:io';
 
 int _httpRequestResponseCode = 0;
 String _httpRequestStatusString;
 List<int> _httpRequestResponse;
@@ skipping 54 matching lines @@
   }
 }
 
 _setPackageRoot(String packageRoot) {
   // TODO(mattsh) - refactor windows drive and path handling code
   // so it can be used here if needed.
   _packageRoot = packageRoot;
 }
 
 String _resolveScriptUri(String cwd, String scriptName, bool isWindows) {
+  var scriptUri = Uri.parse(scriptName);
+  if (scriptUri.scheme == 'http') {

[Søren Gjesse, 2013/06/03 07:12:07]

How about https?

[Ivan Posva, 2013/06/03 07:22:56]

What if the URI we were handed on the command line is using the "file" or
"package" schemes? I am not sure where it is supported to use package based
scripts for the main entry point, but I do not see a reason not to.

[Cutch, 2013/06/03 17:55:37]

Now that we are using the dart:io HttpClient we can support https.

[Cutch, 2013/06/03 17:55:37]

Agreed. This code needs to be cleaned up. I'll do that as a final pass once the
tests land.

+    _entrypoint = scriptUri;
+    _logResolution("# Resolved script to: $_entrypoint");
+    return _entrypoint.toString();
+  }
   _logResolution("# Current working directory: $cwd");
   _logResolution("# ScriptName: $scriptName");
   if (isWindows) {
     // For Windows we need to massage the paths a bit according to
     // http://blogs.msdn.com/b/ie/archive/2006/12/06/file-uris-in-windows.aspx
     //
     // Convert
     // C:\one\two\three
     // to
     // /C:/one/two/three
@@ skipping 101 matching lines @@
     var path = (uri.path != '') ? '${uri.host}${uri.path}' : uri.host;
     var right = 'package:$path';
     var wrong = 'package://$path';
 
     throw "URIs using the 'package:' scheme should look like "
           "'$right', not '$wrong'.";
   }
 
   var path;
   if (_packageRoot != null) {
     path = "${_packageRoot}${uri.path}";

[Ivan Posva, 2013/06/03 07:22:56]

What is confusing in this whole scheme is that if we have a package root that
points to a http based location, then it is just using string concatenation here
and does not go through any of the proper URI handling in this file.

[Cutch, 2013/06/03 17:55:37]

See my other comment. This function needs to be cleaned up for the reasons
you've mentioned and because it has an implicit side effect of setting
_entrypoint which should be made explicit.

   } else {
-    path = _entrypoint.resolve('packages/${uri.path}').path;
+    if (_entrypoint.scheme == 'http') {

[Søren Gjesse, 2013/06/03 07:12:07]

Ditto.

+      path = _entrypoint.resolve('packages/${uri.path}').toString();
+    } else {
+      path = _entrypoint.resolve('packages/${uri.path}').path;
+    }
   }
 
   _logResolution("# Package: $path");
   return path;
 }
 
 String _filePathFromHttpUri(Uri uri) {
   _logResolution('# Path: $uri');
   return uri.toString();
 }