Added basic tests to test the audio player in Files.app.

Added basic tests to test the audio player in Files.app.

This patch tests if the audio player handles OGG audio files properly. The added tests validate if the window has been opened, if the audio tag is loaded and if the title and artist field are filled out correctly.

TBR=yoshiki@chromium.org
TEST=browser_tests
BUG=244146
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202536

[mtomasz, 2013-05-27 07:54:58]

@hirono: PTAL at JS.
@hashimoto: PTAL at C++.

Thanks.

[hashimoto, 2013-05-27 08:17:27]

file_manager_browsertest.cc lgtm

https://codereview.chromium.org/16092002/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/test_util.js (right):

https://codereview.chromium.org/16092002/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/test_util.js:504: if (!request.appId) {
Why this 'if' is changed but not merged with the 'if' above?

[hirono, 2013-05-27 09:09:24]

lgtm

On 2013/05/27 08:17:27, hashimoto wrote:
> file_manager_browsertest.cc lgtm
> 
>
https://codereview.chromium.org/16092002/diff/1/chrome/browser/resources/file...
> File chrome/browser/resources/file_manager/js/test_util.js (right):
> 
>
https://codereview.chromium.org/16092002/diff/1/chrome/browser/resources/file...
> chrome/browser/resources/file_manager/js/test_util.js:504: if (!request.appId)
{
> Why this 'if' is changed but not merged with the 'if' above?

[mtomasz, 2013-05-27 09:14:26]

https://codereview.chromium.org/16092002/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/test_util.js (right):

https://codereview.chromium.org/16092002/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/test_util.js:504: if (!request.appId) {
On 2013/05/27 08:17:27, hashimoto wrote:
> Why this 'if' is changed but not merged with the 'if' above?

Reverted this line, since it is not related to this CL.

[commit-bot: I haz the power, 2013-05-27 09:15:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16092002/7001

[hirono, 2013-05-27 09:15:36]

Sorry, I found 1 nit.
Other parts are still lgtm.

https://codereview.chromium.org/16092002/diff/1/chrome/test/data/extensions/a...
File chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js
(right):

https://codereview.chromium.org/16092002/diff/1/chrome/test/data/extensions/a...
chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js:255:
function(appId) {
The name 'appId' is also used in the outer function.
Could you use 'inAppId' to avoid confusion?

[mtomasz, 2013-05-27 09:18:12]

https://codereview.chromium.org/16092002/diff/1/chrome/test/data/extensions/a...
File chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js
(right):

https://codereview.chromium.org/16092002/diff/1/chrome/test/data/extensions/a...
chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js:255:
function(appId) {
On 2013/05/27 09:15:37, hirono wrote:
> The name 'appId' is also used in the outer function.
> Could you use 'inAppId' to avoid confusion?

Good idea. Done.

[commit-bot: I haz the power, 2013-05-27 09:18:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16092002/8004

[hirono, 2013-05-27 09:19:36]

On 2013/05/27 09:18:26, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/mtomasz%40chromium.org/16092002/8004

Sorry for bothering. Thank you very much for addressing!

[commit-bot: I haz the power, 2013-05-27 09:55:00]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-28 04:29:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16092002/21001

[commit-bot: I haz the power, 2013-05-28 05:37:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16092002/16002

[commit-bot: I haz the power, 2013-05-28 08:14:24]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-05-28 09:17:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16092002/16002

[commit-bot: I haz the power, 2013-05-28 09:17:28]

Failed to apply patch for
chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc
  Hunk #1 FAILED at 66.
  Hunk #2 succeeded at 334 (offset -249 lines).
  Hunk #3 FAILED at 648.
  Hunk #4 succeeded at 502 with fuzz 2 (offset -281 lines).
  2 out of 4 hunks FAILED -- saving rejects to file
chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc.rej

Patch:      
chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc
Index:
chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc
diff --git
a/chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc
b/chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc
index
570e6f3c71b0b646663778365ebe5380d4c325ca..10f6a2946d4179a978b7cd65019ce6bbb1a1ce7d
100644
---
a/chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc
+++
b/chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc
@@ -66,6 +66,8 @@ TestEntryInfo kTestEntrySetCommon[] = {
   { FILE, "text.txt", "hello.txt", "text/plain", NONE, "4 Sep 1998 12:34:56" },
   { FILE, "image.png", "My Desktop Background.png", "text/plain", NONE,
     "18 Jan 2038 01:02:03" },
+  { FILE, "music.ogg", "Beautiful Song.ogg", "text/plain", NONE,
+    "12 Nov 2086 12:00:00" },
   { FILE, "video.ogv", kKeyboardTestFileName, "text/plain", NONE,
     "4 July 2012 10:35:00" },
   { DIRECTORY, "", "photos", NULL, NONE, "1 Jan 1980 23:59:59" },
@@ -583,6 +585,9 @@ class FileManagerBrowserTestBase : public ExtensionApiTest,
   // Runs the gallery open test on the passed |volume|, shared by subclasses.
   void DoTestGalleryOpen(TestVolume* volume);
 
+  // Runs the audio open test on the passed |volume|, shared by subclasses.
+  void DoTestAudioOpen(TestVolume* volume);
+
   // Runs the keyboard copy test on the passed |volume|, shared by subclasses.
   void DoTestKeyboardCopy(TestVolume* volume);
 
@@ -645,6 +650,12 @@ void
FileManagerBrowserTestBase::DoTestGalleryOpen(TestVolume* volume) {
   ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
 }
 
+void FileManagerBrowserTestBase::DoTestAudioOpen(TestVolume* volume) {
+  ResultCatcher catcher;
+  StartTest("audioOpen" + volume->GetName());
+  ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
+}
+
 void FileManagerBrowserTestBase::DoTestKeyboardCopy(TestVolume* volume) {
   base::FilePath copy_path =
       volume->GetRootPath().AppendASCII(kKeyboardTestFileCopyName);
@@ -780,6 +791,14 @@ IN_PROC_BROWSER_TEST_P(FileManagerBrowserDriveTest,
TestGalleryOpen) {
   DoTestGalleryOpen(&volume_);
 }
 
+IN_PROC_BROWSER_TEST_P(FileManagerBrowserLocalTest, TestAudioOpen) {
+  DoTestAudioOpen(&volume_);
+}
+
+IN_PROC_BROWSER_TEST_P(FileManagerBrowserDriveTest, TestAudioOpen) {
+  DoTestAudioOpen(&volume_);
+}
+
 IN_PROC_BROWSER_TEST_P(FileManagerBrowserDriveTest, TestKeyboardCopy) {
   DoTestKeyboardCopy(&volume_);
 }

[commit-bot: I haz the power, 2013-05-28 09:45:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16092002/32004

[commit-bot: I haz the power, 2013-05-28 11:46:13]

Change committed as 202536