Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1609173002: Revert of [runtime] Migrate Object.getOwnPropertyNames to C++. (Closed)

Created:
4 years, 11 months ago by Michael Hablich
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@ObjectGetOwnPropertyDescriptor
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [runtime] Migrate Object.getOwnPropertyNames to C++. (patchset #2 id:20001 of https://codereview.chromium.org/1605803002/ ) Reason for revert: Breaks roll: https://codereview.chromium.org/1603953002/ Original issue's description: > [runtime] Migrate Object.getOwnPropertyNames to C++. > > The Object.getOwnPropertyNames method always calls into C++ anyway, > so there's no point in having the JavaScript wrapper around at all. > > Drive-by-fix: Inline GetOwnEnumerablePropertyNames into its single > call site. > > R=yangguo@chromium.org > > Committed: https://crrev.com/bf027fe756f62b4abcac8aa08134c8c5ed055620 > Cr-Commit-Position: refs/heads/master@{#33380} TBR=yangguo@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/98cd565ff2d19e694040e427a7321074fbbb4306 Cr-Commit-Position: refs/heads/master@{#33399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -25 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/builtins.cc View 2 chunks +4 lines, -21 lines 0 comments Download
M src/js/v8natives.js View 4 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Hablich
Created Revert of [runtime] Migrate Object.getOwnPropertyNames to C++.
4 years, 11 months ago (2016-01-20 08:19:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1609173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1609173002/1
4 years, 11 months ago (2016-01-20 08:19:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1609173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1609173002/1
4 years, 11 months ago (2016-01-20 08:32:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 08:43:56 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 08:44:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98cd565ff2d19e694040e427a7321074fbbb4306
Cr-Commit-Position: refs/heads/master@{#33399}

Powered by Google App Engine
This is Rietveld 408576698