Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1609083002: Remove blink::isWindowsVistaOrGreater. (Closed)

Created:
4 years, 11 months ago by jbroman
Modified:
4 years, 10 months ago
Reviewers:
bungeman-chromium
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1, eae, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove blink::isWindowsVistaOrGreater. Chromium no longer supports Windows XP; see: https://code.google.com/p/chromium/issues/detail?id=579196 BUG=579265 Committed: https://crrev.com/eed2fe380f4a878aae24d4dd986b044edaf297d6 Cr-Commit-Position: refs/heads/master@{#372373}

Patch Set 1 #

Patch Set 2 : set metrics->cbSize properly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -112 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutThemeFontProviderWin.cpp View 1 2 chunks +2 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/platform/win/SystemInfo.h View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/Source/platform/win/SystemInfo.cpp View 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jbroman
R=bungeman because you know about Windows fonts CC=eae because fonts CC=scottmg because Windows
4 years, 10 months ago (2016-01-29 16:37:05 UTC) #3
bungeman-chromium
This does lgtm, though I'm not sure if this directly affects anything to do with ...
4 years, 10 months ago (2016-01-29 17:09:49 UTC) #4
jbroman
On 2016/01/29 at 17:09:49, bungeman wrote: > This does lgtm, though I'm not sure if ...
4 years, 10 months ago (2016-01-29 17:54:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1609083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1609083002/20001
4 years, 10 months ago (2016-01-29 17:56:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-29 18:05:54 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 18:06:57 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eed2fe380f4a878aae24d4dd986b044edaf297d6
Cr-Commit-Position: refs/heads/master@{#372373}

Powered by Google App Engine
This is Rietveld 408576698